Re: [Libguestfs] [libnbd PATCH] copy: Write progress to stderr, not /dev/tty
On 09/02/22 21:53, Eric Blake wrote:
On Fri, Sep 02, 2022 at 06:58:53PM +0100, Richard W.M. Jones wrote:
> On Fri, Sep 02, 2022 at 10:25:38AM -0500, Eric Blake wrote:
>> dd writes progress messages to stderr, with no complaints. Having
>> nbdcopy open /dev/tty instead of reusing stderr to write messages
>> litters the output of a terminal during an interactive 'make check',
>> which is rather distracting, even though that test also ran a second
>> copy using a different fd for inspecting the output.
>>
>> Fixes: 1df1b05a ("New nbdcopy tool", v1.3.8)
>
> ACK
>
> Thanks for looking at this,
Now in as d4d4e70d
How does this affect the situation described in
<https://bugzilla.redhat.com/show_bug.cgi?id=2115621>?
I feel like we should add a comment there, noting that commit d4d4e70d
changes the behavior described previously. I'm unsure about the
specifics though.
Laszlo