Re: [Libguestfs] [nbdkit PATCH] RFC tests: Avoid odd test behavior under NDEBUG

On Tue, Jul 07, 2020 at 09:51:53AM -0500, Eric Blake wrote: > While we support compilation with CFLAGS=-DNDEBUG for the brave user > desiring to avoid assertion overhead, this causes the tests to be less > powerful. Fortunately, a quick test of './configure CFLAGS=-DNDEBUG' > didn't hit any test failures, but it seems better to just ensure that > assertions always work in our tests, even if they are turned off for > the main binary. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > > I don't know if I like this one. Since 'make check' passed in a build > with CFLAGS=-DNDEBUG, I'm not sure we need it. I think we actually do need it. The tests "fail open" if someone compiles with -DNDEBUG so we should ensure that something is being tested even under these conditions. ACK