Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On 20.04.2017 12:19, Pavel Butsykin wrote: >[This sender failed our fraud detection checks and may not be who they >appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > >20.04.2017 10:54, Richard W.M. Jones пишет: > >>On Wed, Apr 19, 2017 at 04:58:56PM +0300, Pavel Butsykin wrote: >>>I dare to raise an old topic :) It seemed to me that this patch >>>already applied, >>>but recently discovered that it is not. >>> >>>As far as I understand we can't do a strict requirement to use Augeas >>>>= 1.7.0. >>I'm not sure I know enough to review this patch, but on the issue > >As I remember the patch was already reviewed, there was only an issue with >aug_transform to existing grub config path. > >>of Augeas 1.7.0: As Augeas 1.7.0 was released nearly 6 months ago, >>I think it would be fine to require it for virt-v2v. If we did >>that does it help? > >Yes, definitely. In this case, we can just apply your previous patch-set - >( https://www.redhat.com/archives/libguestfs/2016-November/msg00059.html ). >After all, the only problem with the bootloader patch is an error when >libguestfs attempts to include the existing path to the Augeas lens. With >Augeas 1.7.0 we get rid of unnecessary calls to aug_transform. > >> ping. Can I expect decision on this issue?