Re: [Libguestfs] [PATCH] lib: remove extra @LIBS@ from pkg-config file
On 3/11/20 7:21 AM, Pino Toscano wrote:
At the moment it is empty, so probably it does not exist. Remove it
to
avoid adding spurious content to the pkg-config file in case that
variable will get a value in the future.
---
lib/libguestfs.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/libguestfs.pc.in b/lib/libguestfs.pc.in
index 679ed7eba..013bf0f28 100644
--- a/lib/libguestfs.pc.in
+++ b/lib/libguestfs.pc.in
@@ -8,4 +8,4 @@ Version: @VERSION@
Description: libguestfs library for accessing and modifying VM images
Requires:
Cflags:
-Libs: -lguestfs @LIBS@
+Libs: -lguestfs
If I recall, @LIBS@ is the user-controlled variable for adding
dependencies on a user-specified library beyond what configure would
normally find. You're right that it is usually empty, but if a user
runs './configure LIBS=...' to pick up something special, then that
something special had better still be present through uses of the
resulting library. Thus, I'm inclined to think we don't want this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org