September 2022 - Libguestfs - libguestfs List Archives

libnbd | Failed pipeline for master | cff5107f
by GitLab 02 Sep '22

02 Sep '22

Pipeline #629919397 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: cff5107f ( https://gitlab.com/nbdkit/libnbd/-/commit/cff5107f4867aaf700f38a10c36f3ae3d… ) Commit Message: api: Silence recent compiler warnings Looks li... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #629919397 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/629919397 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 3 failed jobs. Job #2973029182 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2973029182/raw ) Stage: builds Name: x86_64-macos-11 Job #2973029163 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2973029163/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2973029173 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2973029173/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 55b09667
by GitLab 02 Sep '22

02 Sep '22

Pipeline #629825043 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 55b09667 ( https://gitlab.com/nbdkit/libnbd/-/commit/55b09667060f5c5e4f6ade4d53ffe5370… ) Commit Message: api: Fix nbd_can_meta_context if NBD_OPT_SET_ME... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #629825043 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/629825043 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 22 failed jobs. Job #2972475054 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475054/raw ) Stage: builds Name: x86_64-ubuntu-1804 Job #2972475023 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475023/raw ) Stage: builds Name: x86_64-centos-stream-8 Job #2972475070 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475070/raw ) Stage: builds Name: x86_64-freebsd-current Job #2972475019 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475019/raw ) Stage: builds Name: x86_64-alpine-edge Job #2972475026 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475026/raw ) Stage: builds Name: x86_64-debian-10 Job #2972475066 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475066/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2972475072 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475072/raw ) Stage: builds Name: x86_64-macos-11 Job #2972475051 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475051/raw ) Stage: builds Name: x86_64-opensuse-tumbleweed Job #2972475068 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475068/raw ) Stage: builds Name: x86_64-freebsd-13 Job #2972475060 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475060/raw ) Stage: builds Name: i686-debian-10 Job #2972475048 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475048/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2972475063 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475063/raw ) Stage: builds Name: i686-debian-11 Job #2972475012 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475012/raw ) Stage: builds Name: x86_64-alpine-314 Job #2972475015 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475015/raw ) Stage: builds Name: x86_64-almalinux-8 Job #2972475044 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475044/raw ) Stage: builds Name: x86_64-fedora-rawhide-clang Job #2972475032 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475032/raw ) Stage: builds Name: x86_64-debian-sid Job #2972475030 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475030/raw ) Stage: builds Name: x86_64-debian-11 Job #2972475040 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475040/raw ) Stage: builds Name: x86_64-fedora-36 Job #2972475042 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475042/raw ) Stage: builds Name: x86_64-fedora-rawhide Job #2972475036 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475036/raw ) Stage: builds Name: x86_64-fedora-35 Job #2972475058 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475058/raw ) Stage: builds Name: x86_64-ubuntu-2004 Job #2972475017 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2972475017/raw ) Stage: builds Name: x86_64-almalinux-8-clang -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | ed139c6f
by GitLab 02 Sep '22

02 Sep '22

Pipeline #629546478 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: ed139c6f ( https://gitlab.com/nbdkit/libnbd/-/commit/ed139c6f72293771943438712a75b5836… ) Commit Message: Version 1.15.2. Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #629546478 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/629546478 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #2970722376 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2970722376/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2970722417 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2970722417/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

[libnbd PATCH] RFC: api: Add nbd_supports_vsock()
by Eric Blake 02 Sep '22

02 Sep '22

Similar to nbd_supports_tls(), it is nice to know from a feature probe whether we are likely to have VSOCK support before even trying more expensive APIs like nbd_connect_uri("nbd+vsock://..."). --- https://bugzilla.redhat.com/show_bug.cgi?id=2069558 documents a case where AF_VSOCK is compiled, but vsock still doesn't work because vsock_loopback is not loaded. Should we make nbd_supports_vsock() return true only when ALL aspects of vsock are known to be working? --- generator/API.ml | 25 ++++++++++++++++++++++--- lib/handle.c | 17 +++++++++++++++++ 2 files changed, 39 insertions(+), 3 deletions(-) diff --git a/generator/API.ml b/generator/API.ml index b377b9f..7ec85ca 100644 --- a/generator/API.ml +++ b/generator/API.ml @@ -1393,7 +1393,8 @@ "connect_uri", { =item C<nbds+vsock:> Connect over the C<AF_VSOCK> transport, without or with -TLS respectively. +TLS respectively. You can use L<nbd_supports_vsock(3)> to +see if this build of libnbd supports C<AF_VSOCK>. =back @@ -1494,7 +1495,8 @@ "connect_uri", { see_also = [URLLink "https://github.com/NetworkBlockDevice/nbd/blob/master/doc/uri.md"; Link "aio_connect_uri"; Link "set_export_name"; Link "set_tls"; - Link "set_opt_mode"; Link "get_uri"]; + Link "set_opt_mode"; Link "get_uri"; + Link "supports_vsock"; Link "supports_uri"]; }; "connect_unix", { @@ -1522,8 +1524,12 @@ "connect_vsock", { C<cid> should be C<2> (to connect to the host), and C<port> might be C<10809> or another port number assigned to you by the host administrator. + +Not all systems support C<AF_VSOCK>; to determine if libnbd was +built on a system with vsock support, see L<nbd_supports_vsock(3)>. " ^ blocking_connect_call_description; - see_also = [Link "aio_connect_vsock"; Link "set_opt_mode"]; + see_also = [Link "aio_connect_vsock"; Link "set_opt_mode"; + Link "supports_vsock"]; }; "connect_tcp", { @@ -3061,6 +3067,16 @@ "supports_tls", { see_also = [Link "set_tls"]; }; + "supports_vsock", { + default_call with + args = []; ret = RBool; is_locked = false; may_set_error = false; + shortdesc = "true if libnbd was compiled with support for AF_VSOCK"; + longdesc = "\ +Returns true if libnbd was compiled with support for the AF_VSOCK family +of sockets, or false if not."; + see_also = [Link "connect_vsock"; Link "connect_uri"]; + }; + "supports_uri", { default_call with args = []; ret = RBool; is_locked = false; may_set_error = false; @@ -3233,6 +3249,9 @@ let first_version = "set_request_block_size", (1, 12); "get_request_block_size", (1, 12); + (* Added in 1.13.x development cycle, will be stable and supported in 1.14. *) + "supports_vsock", (1, 14); + (* These calls are proposed for a future version of libnbd, but * have not been added to any released version so far. "get_tls_certificates", (1, ??); diff --git a/lib/handle.c b/lib/handle.c index 8713e18..ac64fe9 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -28,6 +28,12 @@ #include <sys/types.h> #include <sys/wait.h> +#ifdef HAVE_LINUX_VM_SOCKETS_H +#include <linux/vm_sockets.h> +#elif HAVE_SYS_VSOCK_H +#include <sys/vsock.h> +#endif + #include "internal.h" static void @@ -483,6 +489,17 @@ nbd_unlocked_supports_tls (struct nbd_handle *h) #endif } +/* NB: is_locked = false, may_set_error = false. */ +int +nbd_unlocked_supports_vsock (struct nbd_handle *h) +{ +#ifdef AF_VSOCK + return 1; +#else + return 0; +#endif +} + /* NB: is_locked = false, may_set_error = false. */ int nbd_unlocked_supports_uri (struct nbd_handle *h) -- 2.37.2

3 5

libnbd | Failed pipeline for master | f8b2b4fc
by GitLab 01 Sep '22

01 Sep '22

Pipeline #629253211 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: f8b2b4fc ( https://gitlab.com/nbdkit/libnbd/-/commit/f8b2b4fcc9ac4baa0219b1f3e119e7a8d… ) Commit Message: api: Add nbd_supports_vsock() Similar to nbd_s... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #629253211 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/629253211 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2969109074 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2969109074/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2969109081 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2969109081/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 32f02567
by GitLab 01 Sep '22

01 Sep '22

Pipeline #629217927 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 32f02567 ( https://gitlab.com/nbdkit/libnbd/-/commit/32f02567d50c009e835a3a167cf5e1a99… ) Commit Message: maint: Better xfuncname for states-*.c diffs G... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #629217927 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/629217927 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2968897066 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2968897066/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2968897074 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2968897074/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0