September 2022 - Libguestfs - Libguestfs List Archives

[PATCH libnbd v3 0/6] Additional non-NULL warnings, checks and docs

by Richard W.M. Jones

v2: https://listman.redhat.com/archives/libguestfs/2022-September/030014.html I didn't think this would need a v3, but here we are. The first patch (also a new patch) appears to fix a bug in Eric's earlier series to do with meta queries. It's not possible to call the new APIs with queries == NULL, and this becomes obvious when you use attribute((nonnull)) and enable GCC warnings. I tried to fix this, but two tests still fail for reasons I'm not clear about: FAIL: opt-list-meta-queries FAIL: opt-set-meta-queries The third patch is also new, and extends attribute((nonnull)) annotations to many internal functions. No actual errors found by this, but it seems worth it to avoid future problems, assuming that GCC won't start adding undefined behaviour. I wonder aloud if we should only enable attribute((nonnull)) for developer builds, ie. tie it to ./configure --enable-gcc-warnings somehow. (This series does not do this.) I added comments as suggested by Laszlo to patch 2, and picked up his R-b's and Acks. Rich.

2 years, 2 months

3
25
0 / 0

libnbd | Failed pipeline for master | e62a558f

by GitLab

Pipeline #654197984 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: e62a558f ( https://gitlab.com/nbdkit/libnbd/-/commit/e62a558f74aa06b179ab9c802a2d177... ) Commit Message: lib/utils.c: Assert that argv != NULL and add c... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #654197984 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/654197984 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #3104490803 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3104490803/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #3104490825 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3104490825/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

2 years, 2 months

1
0
0 / 0

[PATCH libnbd v2 0/4] Additional non-NULL warnings, checks and docs

by Richard W.M. Jones

v1 was: https://listman.redhat.com/archives/libguestfs/2022-September/029982.html This series is actually quite a bit different from v1 because it is rebased on top of Eric's series and takes that into account. Generally this heads down the return error instead of asserting route, hoping that the GCC annotations will be sufficient to catch as many errors as possible at compile time. Rich.

2 years, 2 months

2
13
0 / 0

ZFS-on-NBD

by Nikolaus Rath

Hi all, In case people have been wondering about the background of the various questions that I asked on these lists in the last few months: I've been experimenting with running ZFS-on-NBD as a cloud backup solution (and potential alternative to S3QL, which I am using for this purpose at the moment). In case someone is interested, here is the (rather long) write-up: https://www.rath.org/s3ql-vs-zfs-on-nbd.html Best, -Nikolaus -- GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F »Time flies like an arrow, fruit flies like a Banana.«

2 years, 2 months

4
4
0 / 0

[p2v PATCH 0/2] restrict supported GLIB2 and GTK3 versions

by Laszlo Ersek

Remove GTK3 compat code that is not needed on RHEL7+. Incorporate suggestions from Rich and Daniel in the subthread at <https://listman.redhat.com/archives/libguestfs/2022-September/029940.html>. Do not remove "gui-gtk3-compat.h" altogether; I expect we may have to add in new compat stuff in the future, and having to redo the infrastructure for that is not a great prospect. Laszlo Laszlo Ersek (2): require GLIB2 >= 2.56 and GTK3 >= 3.22; enhance API compatibility remove old GLIB2 / GTK3 compat code Makefile.am | 4 ++ docs/p2v-building.pod | 6 +- gui-gtk3-compat.h | 46 ------------- gui.c | 69 ++------------------ m4/p2v-libraries.m4 | 5 +- 5 files changed, 16 insertions(+), 114 deletions(-)

2 years, 2 months

3
5
0 / 0

libnbd | Failed pipeline for master | 21b279a7

by GitLab

Pipeline #653902609 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 21b279a7 ( https://gitlab.com/nbdkit/libnbd/-/commit/21b279a78eefda92ce8dab589df31a6... ) Commit Message: lib: Free h->querylist correctly *_reset only ... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #653902609 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/653902609 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #3102791148 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3102791148/raw ) Stage: builds Name: x86_64-freebsd-12 Job #3102791140 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3102791140/raw ) Stage: builds Name: x86_64-opensuse-leap-153 -- You're receiving this email because of your account on gitlab.com.

2 years, 2 months

1
0
0 / 0

test message, please ignore...

by Laszlo Ersek

(I'm trying to figure out why the patch set I just posted isn't appearing in my mailbox and in the web archive. Did I mess up the sending, or is the list software having a bad day?)

2 years, 2 months

1
1
0 / 0

Re: [Libguestfs] can not get the virt-sparsify code in libguestfs ?

by Richard W.M. Jones

On Thu, Sep 22, 2022 at 11:48:17AM +0000, Li, Feng F wrote: > 2) https://libguestfs.org/virt-sparsify.1.html > > we downloaded the libguestfs (1.48-stable) library ,but after the > configure and make, we did not found the virt-sparsify source code > and binary file, would you please help see where to get the > virt-sparsify source code for debug ? virt-sparsify and some other tools were recently moved into a new repository: https://github.com/rwmjones/guestfs-tools Most Linux distros already ship these tools. You shouldn't really need to compile it all from source yourself (although of course it is possible and you are welcome to try). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

2 years, 3 months

3
12
0 / 0

[PATCH libnbd 0/5] generator: Add attribute((nonnull)) annotations

by Richard W.M. Jones

This patch series adds nonnull annotations for parameters which should be non-NULL. There was much discussion on IRC about whether this is a good idea, pointing in particular to the bug below which is still present in modern GCC. It's better to have these discussions on list so they're archived. https://bugzilla.redhat.com/show_bug.cgi?id=1041336 There's a possible follow-up patch which *removes* all the pointer == NULL tests added in the final patch, again something for discussion. See my view on this topic here (and Eric's follow up): https://listman.redhat.com/archives/libguestfs/2022-September/029966.html Rich.

2 years, 3 months

3
12
0 / 0

[p2v PATCH 0/7] remove GTK2 support

by Laszlo Ersek

At Rich's suggestion at http://mid.mail-archive.com/20220923095410.GD7773@redhat.com this series turns GTK3 into a fixed requirement for virt-p2v, also removing GTK2 support code. Along the way, some issues that I've just discovered are fixed. I've checked the series at every stage, plugging the command git clean -ffdx && git reset --hard && git submodule deinit --force --all && autoreconf -i && ./configure --enable-werror && make -j10 && make -j10 check && make dist maintainer-check-extra-dist into git rebase --exec '...' master I've verified the end result with "make run-virt-p2v-directly" and via a freshly built Live ISO. The HTML-rendered build instructions look good to me, too. Laszlo Laszlo Ersek (7): "shutdown_actions": suppress "missing initializer" warnings/errors contrib/: remove directory require GTK3 gui.c: remove line truncation (originally a workaround for a GTK2 bug) gui.c: fix warning label wrapping regression under GTK3 remove GTK2 compat code gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version Makefile.am | 11 +- contrib/aux-scripts/do-build.sh | 196 -------------------- contrib/build-p2v-iso.sh | 154 --------------- contrib/patches/0001-RHEL-5-ONLY-DISABLE-AUTOMATIC-REMOTE-PORT-ALLOCATION.patch | 54 ------ contrib/test-p2v-iso.sh | 62 ------- dependencies.m4 | 10 +- docs/p2v-building.pod | 11 +- gui-gtk2-compat.h | 116 ------------ gui.c | 78 +------- m4/p2v-libraries.m4 | 32 +--- 10 files changed, 18 insertions(+), 706 deletions(-) delete mode 100644 contrib/aux-scripts/do-build.sh delete mode 100755 contrib/build-p2v-iso.sh delete mode 100644 contrib/patches/0001-RHEL-5-ONLY-DISABLE-AUTOMATIC-REMOTE-PORT-ALLOCATION.patch delete mode 100755 contrib/test-p2v-iso.sh delete mode 100644 gui-gtk2-compat.h

2 years, 3 months

3
20
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs September 2022