October 2018 - Libguestfs - libguestfs List Archives

[PATCH 0/2] v2v: uninstall VMware tools on all Linux guests
by Pino Toscano 04 Oct '18

04 Oct '18

Hi, this patch series attempt to uninstall VMware tools on all the Linux guests, and reduce the uninstallation time needed in some cases: - v2v tries to workaround the slowest part of the tarball-installed VMware tools - v2v uninstalls the open source VMware tools (open-vm-tools) Thanks, Pino Toscano (2): v2v: linux: remove open-vm-tools packages v2v: linux: try to trick vmware-uninstall-tools.pl v2v/convert_linux.ml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) -- 2.17.1

2 3

[PATCH 0/2] Use common macros to help with libxml2 writer.
by Richard W.M. Jones 04 Oct '18

04 Oct '18

Consolidate and extend the use of funky start_element() etc macros. Rich.

1 2

[PATCH v2 API PROPOSAL 0/5] inspection Add network interfaces to inspection data.
by Richard W.M. Jones 03 Oct '18

03 Oct '18

The proposed API is the same as v1, but this includes an implementation (for /etc/sysconfig/network-scripts/ifcfg-*) and modifications to virt-inspector. This compiles and works. If you look in patch 5 you can see proposed output as virt-inspector XML for a guest (although this guest has not been booted, so a real guest would hopefully have a hwaddr="MAC" attribute too). Rich.

2 7

[PATCH] rpm: generalize openSUSE support
by Pino Toscano 02 Oct '18

02 Oct '18

It seems that all the newer versions of openSUSE have an 'opensuse-' prefix in their distro ID; hence, check for that prefix at once, keeping compatibility for the old "opensuse" ID. Followup of commit a4e53bcbc52594f8863e7866448640f7ac8ab0f9. --- m4/guestfs-appliance.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs-appliance.m4 b/m4/guestfs-appliance.m4 index bcba4c1a1..0a3d6133a 100644 --- a/m4/guestfs-appliance.m4 +++ b/m4/guestfs-appliance.m4 @@ -105,7 +105,7 @@ AC_ARG_WITH([distro], DISTRO="`. /etc/os-release && echo $ID | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@'`" AS_CASE([$DISTRO], [FEDORA | RHEL | CENTOS],[DISTRO=REDHAT], - [OPENSUSE-LEAP | OPENSUSE | SLED | SLES],[DISTRO=SUSE], + [OPENSUSE* | SLED | SLES],[DISTRO=SUSE], [ARCH],[DISTRO=ARCHLINUX]) AC_MSG_RESULT([$DISTRO (from /etc/os-release)]) else -- 2.17.1

2 1

Re: [Libguestfs] VM migration help required.
by Arik Hadas 02 Oct '18

02 Oct '18

On Mon, Oct 1, 2018 at 12:25 PM Nitin Rane <Nitin.Rane(a)techmahindra.com> wrote: > Hi Arik,Shahar, > (Adding libguestfs mailing-list) Hi Nitin, > I am looking to migrate VMs from Openstack Juno to Openstack Newton and > from VMWare to Openstack Newton. > > While doing google search I came across the link authored by you, > https://ovirt.org/develop/release-management/features/virt/virt-v2v-integra… > . > > Did the tool discussed in the link would be suitable for above requirement > ? > I did not find any download link of the tool, if the tool is open source > then can you share the download link. > No, that feature is about wrapping virt-v2v in order to provide end-users of oVirt with a better process for importing VMs to oVirt. It is irrelevant for OpenStack. > > > Right now I am looking to execute a PoC project to demonstrate that the > “VM migration from Openstack Juno to Openstack Newton and from VMWare to > Openstack Newton” is possible using virt-v2v. > The virt-v2v tool, which is part of libguestfs, is ideal for converting VMs from foreign hypervisors to KVM, and from VMware to OpenStack in particular, see [1]. However, as far as I know, it is not supposed to be used for converting from one version of OpenStack to another, you could probably do that differently. [1] http://libguestfs.org/virt-v2v.1.html > > > Regards > > Nitin Rane > > Hinjawadi | 256118 | +919822300715 > > > > > ============================================================================================================================ > > Disclaimer: This message and the information contained herein is > proprietary and confidential and subject to the Tech Mahindra policy > statement, you may review the policy at > http://www.techmahindra.com/Disclaimer.html externally > http://tim.techmahindra.com/tim/disclaimer.html internally within > TechMahindra. > > > ============================================================================================================================ >

4 4

[supermin PATCH] rpm: generalize openSUSE support
by Pino Toscano 02 Oct '18

02 Oct '18

It seems that all the newer versions of openSUSE have an 'opensuse-' prefix in their distro ID; hence, check for that prefix at once, keeping compatibility for the old "opensuse" ID. Followup of commit 0668b2d64abef0724219480a3d7fc16b8dd1e68f. --- src/ph_rpm.ml | 3 ++- tests/test-harder.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ph_rpm.ml b/src/ph_rpm.ml index 3caa38e..46b7f1f 100644 --- a/src/ph_rpm.ml +++ b/src/ph_rpm.ml @@ -40,7 +40,8 @@ let fedora_detect () = let opensuse_detect () = Config.rpm <> "no" && Config.rpm2cpio <> "no" && rpm_is_available () && Config.zypper <> "no" && - (List.mem (Os_release.get_id ()) [ "opensuse-leap"; "opensuse"; "sled"; "sles" ] || + (List.mem (Os_release.get_id ()) [ "sled"; "sles" ] || + string_prefix "opensuse" (Os_release.get_id ()) || try (stat "/etc/SuSE-release").st_kind = S_REG with Unix_error _ -> false) let mageia_detect () = diff --git a/tests/test-harder.sh b/tests/test-harder.sh index 54362de..c827f13 100755 --- a/tests/test-harder.sh +++ b/tests/test-harder.sh @@ -29,7 +29,7 @@ if [ -f /etc/os-release ]; then distro=$(. /etc/os-release && echo $ID) case "$distro" in fedora|rhel|centos) distro=redhat ;; - opensuse-leap|opensuse|sled|sles) distro=suse ;; + opensuse*|sled|sles) distro=suse ;; ubuntu) distro=debian ;; esac elif [ -f /etc/arch-release ]; then -- 2.17.1

2 1

[PATCH API PROPOSAL 0/2] inspection: Add network interfaces to inspection data.
by Richard W.M. Jones 02 Oct '18

02 Oct '18

As part of the fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1626503 I'm proposing to add two new APIs to fetch information about the list of network interfaces of an existing guest. These two patches outline the proposed API but with no implementation or tests. However they can be applied and compiled. Please see the second patch for the proposed API. I have a mostly working implementation for Red Hat-style ifcfg-* files, and both Debian /etc/network/interfaces and Windows registry look do-able using the same architecture. Rich.

2 4

[PATCH v2] v2v: -o rhv-upload: test-v2v-o-rhv-upload.sh: add more skip checks
by Pino Toscano 01 Oct '18

01 Oct '18

-o rhv-upload requires python3, and nbdkit with the python3 plugin, so skip this test if they are not installed. --- v1 is: https://www.redhat.com/archives/libguestfs/2018-October/msg00008.html v2v/test-v2v-o-rhv-upload.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/test-v2v-o-rhv-upload.sh b/v2v/test-v2v-o-rhv-upload.sh index 8bda7cc0b..23d2ad7a0 100755 --- a/v2v/test-v2v-o-rhv-upload.sh +++ b/v2v/test-v2v-o-rhv-upload.sh @@ -28,6 +28,8 @@ set -x $TEST_FUNCTIONS skip_if_skipped skip_if_backend uml +skip_unless python3 --version +skip_unless nbdkit python3 --version skip_unless_phony_guest windows.img libvirt_uri="test://$abs_top_builddir/test-data/phony-guests/guests.xml" -- 2.17.1

2 2

[PATCH] build: support openSUSE Leap 15.0
by Pino Toscano 01 Oct '18

01 Oct '18

Support the ID found in openSUSE Leap 15.0 in addition to the other SUSE-related IDs. While there is already --with-distro=ID to force the ID without using os-release, this makes it possible to build OOTB. --- m4/guestfs-appliance.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs-appliance.m4 b/m4/guestfs-appliance.m4 index 5c2bc3e8d..bcba4c1a1 100644 --- a/m4/guestfs-appliance.m4 +++ b/m4/guestfs-appliance.m4 @@ -105,7 +105,7 @@ AC_ARG_WITH([distro], DISTRO="`. /etc/os-release && echo $ID | tr '@<:@:lower:@:>@' '@<:@:upper:@:>@'`" AS_CASE([$DISTRO], [FEDORA | RHEL | CENTOS],[DISTRO=REDHAT], - [OPENSUSE | SLED | SLES],[DISTRO=SUSE], + [OPENSUSE-LEAP | OPENSUSE | SLED | SLES],[DISTRO=SUSE], [ARCH],[DISTRO=ARCHLINUX]) AC_MSG_RESULT([$DISTRO (from /etc/os-release)]) else -- 2.17.1

2 1

[PATCH nbdkit] plugins: Add scripting language version to --dump-plugin output.
by Richard W.M. Jones 01 Oct '18

01 Oct '18

On Lua: lua_version=5.3.4 On Perl: perl_version=5.28.0 On Python 2: python_version=2.7.15 On Python 3: python_version=3.7.0 python_pep_384_abi_version=3 On Ruby 2.5.1p57: ruby_api_version=2.5.0 On Tcl: tcl_version=8.6 tcl_patch_level=8.6.8 --- plugins/lua/lua.c | 11 +++++++++++ plugins/perl/perl.c | 4 ++++ plugins/python/python.c | 8 ++++++++ plugins/ruby/ruby.c | 14 ++++++++++++++ plugins/tcl/tcl.c | 8 ++++++++ 5 files changed, 45 insertions(+) diff --git a/plugins/lua/lua.c b/plugins/lua/lua.c index a73a4da..2bad44c 100644 --- a/plugins/lua/lua.c +++ b/plugins/lua/lua.c @@ -102,6 +102,17 @@ function_defined (const char *name) static void lua_plugin_dump_plugin (void) { +#ifdef LUA_VERSION_MAJOR + printf ("lua_version=%s", LUA_VERSION_MAJOR); +#ifdef LUA_VERSION_MINOR + printf (".%s", LUA_VERSION_MINOR); +#ifdef LUA_VERSION_RELEASE + printf (".%s", LUA_VERSION_RELEASE); +#endif +#endif + printf ("\n"); +#endif + if (script && function_defined ("dump_plugin")) { lua_getglobal (L, "dump_plugin"); if (lua_pcall (L, 0, 0, 0) != 0) { diff --git a/plugins/perl/perl.c b/plugins/perl/perl.c index 3fce279..4cee89d 100644 --- a/plugins/perl/perl.c +++ b/plugins/perl/perl.c @@ -169,6 +169,10 @@ perl_dump_plugin (void) { dSP; +#ifdef PERL_VERSION_STRING + printf ("perl_version=%s\n", PERL_VERSION_STRING); +#endif + if (script && callback_defined ("dump_plugin")) { ENTER; SAVETMPS; diff --git a/plugins/python/python.c b/plugins/python/python.c index ef1a2cf..8b16d7e 100644 --- a/plugins/python/python.c +++ b/plugins/python/python.c @@ -259,6 +259,14 @@ py_dump_plugin (void) PyObject *fn; PyObject *r; +#ifdef PY_VERSION + printf ("python_version=%s\n", PY_VERSION); +#endif + +#ifdef PYTHON_ABI_VERSION + printf ("python_pep_384_abi_version=%d\n", PYTHON_ABI_VERSION); +#endif + if (script && callback_defined ("dump_plugin", &fn)) { PyErr_Clear (); diff --git a/plugins/ruby/ruby.c b/plugins/ruby/ruby.c index aa57f65..a3d7a42 100644 --- a/plugins/ruby/ruby.c +++ b/plugins/ruby/ruby.c @@ -41,6 +41,9 @@ #include <nbdkit-plugin.h> #include <ruby.h> +#ifdef HAVE_RUBY_VERSION_H +#include <ruby/version.h> +#endif static VALUE nbdkit_module = Qnil; static int last_error; @@ -168,6 +171,17 @@ plugin_rb_unload (void) static void plugin_rb_dump_plugin (void) { +#ifdef RUBY_API_VERSION_MAJOR + printf ("ruby_api_version=%d", RUBY_API_VERSION_MAJOR); +#ifdef RUBY_API_VERSION_MINOR + printf (".%d", RUBY_API_VERSION_MINOR); +#ifdef RUBY_API_VERSION_TEENY + printf (".%d", RUBY_API_VERSION_TEENY); +#endif +#endif + printf ("\n"); +#endif + if (!script) return; diff --git a/plugins/tcl/tcl.c b/plugins/tcl/tcl.c index b814195..b30fefd 100644 --- a/plugins/tcl/tcl.c +++ b/plugins/tcl/tcl.c @@ -95,6 +95,14 @@ proc_defined (const char *name) static void tcl_dump_plugin (void) { +#ifdef TCL_VERSION + printf ("tcl_version=%s\n", TCL_VERSION); +#endif + +#ifdef TCL_PATCH_LEVEL + printf ("tcl_patch_level=%s\n", TCL_PATCH_LEVEL); +#endif + if (script && proc_defined ("dump_plugin")) { int r; Tcl_Obj *cmd; -- 2.19.0.rc0

2 2