March 2010 - Libguestfs - libguestfs List Archives

[PATCH 0/2] Add readonly=on option to qemu -drive command line
by Richard W.M. Jones 17 Mar '10

17 Mar '10

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

3 7

[PATCH for discussion only] add_drive_ro adds readonly=on option if available.
by Richard W.M. Jones 16 Mar '10

16 Mar '10

This needs more testing. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

1 1

Debian libguestfs packages updated
by Guido Günther 16 Mar '10

16 Mar '10

Hi, I finally updated the Debian libguestfs packages: http://honk.sigxcpu.org/con/Libguestfs__Virtual_Machine_Image_Swiss_Army_Kn… Sine we can't run the fuse tests easily in a chroot (since we might be unable to load the module) I'm using the attached patch to skip the tests if /dev/fuse doesn't exist. This probably isn't clean enough to go upstream though. The other patch adjusts the test output of rhbz557655. xstrtol seems to be behaving differently here. I didn't investigate why yet. As a last point: is there a simple way to disable the appliance build altogether? I'd like to ship the Debian package without it so we stay out of the security update trouble and provide them via http. Cheers and thanks for that great tool, -- Guido

2 4

[PATCH] Add minimal vim to the appliance for virt-rescue.
by Richard W.M. Jones 16 Mar '10

16 Mar '10

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

1 0

[PATCH] Non-working support for GObject Introspection.
by Richard W.M. Jones 16 Mar '10

16 Mar '10

Read the README file at the top of this patch first. Problems I see with GObject Introspection: (1) Requires that your code uses GObject; obvious in hindsight given the name. In this case, it seems that we'd have to "register" the guestfs_h structure with GObject (whatever that means). (2) Cannot convert C error codes into exceptions automatically. So all your high level code has to check return values -- ugh. (3) Poor type system (although at least it does have a concept of non-nullable types). For example, you cannot express 31 bit ints, or range types, dependent types, constructed types, etc etc etc. So I think it's OK if your code depends on glib, but for general C interfaces I cannot see this catching on at the moment. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 7

[PATCH FOR DISCUSSION ONLY] Rewrite libguestfs-supermin-helper in C.
by Richard W.M. Jones 12 Mar '10

12 Mar '10

This needs loads more testing before we include it. However it's in good shape for testing and review. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

2 6

[PATCH] guestfish: Use xstrtoll to parse Int params (RHBZ#569757 RHBZ#567567).
by Richard W.M. Jones 12 Mar '10

12 Mar '10

Fix for the two bugs noted in $SUBJECT. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html

1 0

[PATCH] ExecHelper: Use tmpfile() instead of File::Temp->new()
by Matthew Booth 09 Mar '10

09 Mar '10

Building on EL-5 fails when the result of File::Temp->new() is passed to open3(). tmpfile() works consistently. --- lib/Sys/VirtV2V/ExecHelper.pm | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Sys/VirtV2V/ExecHelper.pm b/lib/Sys/VirtV2V/ExecHelper.pm index 110ae9f..f577ff6 100644 --- a/lib/Sys/VirtV2V/ExecHelper.pm +++ b/lib/Sys/VirtV2V/ExecHelper.pm @@ -20,7 +20,7 @@ package Sys::VirtV2V::ExecHelper; use strict; use warnings; -use File::Temp; +use File::Temp qw(:POSIX); use IPC::Open3; use POSIX ":sys_wait_h"; @@ -71,7 +71,7 @@ sub run my $null; open($null, '<', '/dev/null') or die("Failed to open /dev/null: $!"); - my $output = File::Temp->new(); + my $output = tmpfile(); my $pid = open3($null, $output, $output, @command); waitpid($pid, 0); -- 1.6.6.1

2 1

[PATCH virt-v2v] Remove useless use of 'use_windows_registry' flag.
by Richard W.M. Jones 08 Mar '10

08 Mar '10

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html

2 2

[PATCH] ExecHelper: Code cleanup
by Matthew Booth 08 Mar '10

08 Mar '10

--- lib/Sys/VirtV2V/ExecHelper.pm | 18 +++++------------- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/lib/Sys/VirtV2V/ExecHelper.pm b/lib/Sys/VirtV2V/ExecHelper.pm index 87f6d06..110ae9f 100644 --- a/lib/Sys/VirtV2V/ExecHelper.pm +++ b/lib/Sys/VirtV2V/ExecHelper.pm @@ -68,25 +68,17 @@ sub run my $self = {}; bless($self, $class); - $self->{output} = File::Temp->new(); - $self->{status} = $self->_run(@command); - - return $self; -} - -sub _run -{ - my $self = shift; - my @command = @_; - - my $output = $self->{output}; - my $null; open($null, '<', '/dev/null') or die("Failed to open /dev/null: $!"); + my $output = File::Temp->new(); my $pid = open3($null, $output, $output, @command); waitpid($pid, 0); + $self->{status} = $? >> 8; + $self->{output} = $output; + + return $self; } =item status -- 1.6.6.1

2 1