[PATCH virt-v2v] Remove useless use of 'use_windows_registry' flag.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
On 08/03/10 16:23, Richard W.M. Jones wrote:
From ebb99ee14b5e44b5614ab1c9ca76482f9c81f7b0 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Mon, 8 Mar 2010 16:20:10 +0000 Subject: [PATCH] Remove useless use of 'use_windows_registry' flag.
It was effectively doing this: Sys::Guestfs::Lib::inspect_all_partitions (..., use_windows_registry => undef); That has no effect, and in any case I'm going to remove that flag from inspect_all_partitions in a future release of libguestfs. --- v2v/virt-v2v.pl | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
On Mon, Mar 08, 2010 at 05:16:45PM +0000, Matthew Booth wrote:
On 08/03/10 16:23, Richard W.M. Jones wrote:
From ebb99ee14b5e44b5614ab1c9ca76482f9c81f7b0 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Mon, 8 Mar 2010 16:20:10 +0000 Subject: [PATCH] Remove useless use of 'use_windows_registry' flag.
It was effectively doing this: Sys::Guestfs::Lib::inspect_all_partitions (..., use_windows_registry => undef); That has no effect, and in any case I'm going to remove that flag from inspect_all_partitions in a future release of libguestfs. --- v2v/virt-v2v.pl | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
ACK.
I don't see to have enough mojo to be able to push this. 'ssh' seems to succeed, but then it looks like there is some sort of git permissions problem: $ git push Counting objects: 7, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 528 bytes, done. Total 4 (delta 3), reused 0 (delta 0) error: unable to create temporary sha1 filename ./objects/tmp_obj_k8I13R: Permission denied fatal: failed to write object error: unpack failed: unpacker exited with error code To ssh://git.fedorahosted.org/git/virt-v2v.git ! [remote rejected] master -> master (n/a (unpacker error)) error: failed to push some refs to 'ssh://git.fedorahosted.org/git/virt-v2v.git' Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
participants (2)
-
Matthew Booth -
Richard W.M. Jones