Re: [Libguestfs] [PATCH] osinfo: revamp db reading (RHBZ#1359652)
On Tuesday, 26 July 2016 11:16:07 CEST Richard W.M. Jones wrote:
On Mon, Jul 25, 2016 at 05:47:05PM +0200, Pino Toscano wrote:
> + if (path == NULL)
> + path = "/usr/share/osinfo";
I wonder if we should use $prefix here. I guess there are
arguments both ways.
The specification defines that directory as fallback. Also, $prefix
would be libguestfs' own, not osinfo's.
Should we just run the external osinfo-query program?
Unfortunately, it does not expose all the information we need.
Anyway it's fine as it stands, so ACK.
Thanks, pushed.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)