Re: [Libguestfs] Remaining syntax-check errors in libguestfs

>> trailing_blank >> TODO:405: - swap devices (both of block device and file) should be > wiped. This may >> Binary file tests/guests/guest-aux/windows-software matches >> Binary file tests/guests/guest-aux/windows-system matches >> tools/virt-win-reg:711: >> maint.mk: found trailing blank(s) >> make: *** [sc_trailing_blank] Error 1 > > Binary files should probably not be matched. Hey! I've just realized that I can easily filter out those lines. Here's yet another patch. We should be able to use a similar change for a few other rules. diff --git a/top/maint.mk b/top/maint.mk index 4627bc5..ccf09a2 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -724,6 +724,7 @@ sc_require_test_exit_idiom: sc_trailing_blank: @prohibit='[ ]$$' \ halt='found trailing blank(s)' \ + exclude='^Binary file .* matches$$' \ $(_sc_search_regexp) # Match lines like the following, but where there is only one space