Re: [Libguestfs] [PATCH v2 7/7] v2v: rvh-upload: Match nbdkit threads to qemu-img coroutines

On Mon, Jan 25, 2021 at 01:44:26PM +0200, Nir Soffer wrote: > On Mon, Jan 25, 2021 at 11:58 AM Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: > > > > > > This series is fine apart from two typos. You can push it > > if you want, unless you want to do more testing/tweaking. > > I want to test it first with a real environment since my tests are > not stable. > > Also I'm worried about using -W for all conversion - we should use it only > if the output is using parallel thread model, otherwise it does not give > any benefit and it will may cause unwanted fragmentation in the target > image. > > Should we have something like: > > if output#parallel then > use unordered writes... > > What do you think? Yes, good idea. Although maybe output#write_out_of_order is better as that is how the qemu-img -W option is described in the docs.

Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html