Re: [Libguestfs] [PATCH v2 5/6] New API: yara_scan
On Wednesday, 9 November 2016 22:38:56 CET Matteo Cafasso wrote:
+static char *
+make_temp_file (guestfs_h *g, const char *name)
+{
+ int ret = 0;
+
+ ret = guestfs_int_lazy_make_tmpdir (g);
+ if (ret < 0)
+ return NULL;
+
+ return safe_asprintf (g, "%s/%s%d", g->tmpdir, name, ++g->unique);
+}
Please do not bring a copy of this from src/tsk.c -- instead, first
make it an internal API:
- name it like guestfs_int_make_temp_file
- implemented in src/tmpdirs.c
- declared in src/guestfs-internal.h
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)