Re: [Libguestfs] [p2v PATCH 6/6] Makefile.am: set vCPU topology to 1*2*2 in the "p2v in a VM" tests
On Mon, Sep 05, 2022 at 01:25:31PM +0200, Laszlo Ersek wrote:
This lets us exercise both states of the
"p2v.vcpu.dense_topo" switch
sensibly via the in-VM GUI.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1590721
Signed-off-by: Laszlo Ersek <lersek(a)redhat.com>
---
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index f2fe0e3efc99..19c5f04c2fab 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -268,6 +268,7 @@ run-virt-p2v-in-a-vm: virt-p2v.img $(PHYSICAL_MACHINE)
$(shell guestfish get-hv) \
-M pc,accel=kvm:tcg \
-cpu host \
+ -smp sockets=1,cores=2,threads=2 \
-m 2048 \
-drive id=hd0,file=$(PHYSICAL_MACHINE),format=raw,if=ide \
-device qemu-xhci \
@@ -287,6 +288,7 @@ run-virt-p2v-in-an-nvme-vm: virt-p2v.img $(PHYSICAL_MACHINE)
$(BLANK_DISK)
$(shell guestfish get-hv) \
-M pc,accel=kvm:tcg \
-cpu host \
+ -smp sockets=1,cores=2,threads=2 \
-m 2048 \
-boot menu=on \
\
Whole series looks good, so ACK as it is except for the minor inline
comments I made.
You might consider changing s/dense_topo/full_topo/ (or complete_topo)
everywhere if you want.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit