Re: [Libguestfs] [PATCH 1/6] v2v: output_rhv_upload: Require nbdkit >= 1.22

nbdkit 1.22 provides API_VERSION 2 and parallel threading model for the python plugin. This version is available in RHEL AV 8.3.0. Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt; --- v2v/output_rhv_upload.ml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml index b5cc95b9..08d6dd25 100644 --- a/v2v/output_rhv_upload.ml +++ b/v2v/output_rhv_upload.ml @@ -84,11 +84,11 @@ let parse_output_options options = { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids } -(* In theory even very old versions of nbdkit might work, but as - * with [Nbdkit_sources] check for at least 1.12. +(* We need nbdkit >= 1.22 for API_VERSIO 2 and parellel threading model in the

+ * python plugin. *) -let nbdkit_min_version = (1, 12, 0) -let nbdkit_min_version_string = "1.12.0" +let nbdkit_min_version = (1, 22, 0) +let nbdkit_min_version_string = "1.22.0" let nbdkit_python_plugin = Config.nbdkit_python_plugin let pidfile_timeout = 30 -- 2.26.2