Re: [Libguestfs] [PATCH 3/3] src: print contents of structs and struct lists on tracing
On Thursday 25 February 2016 12:31:30 Richard W.M. Jones wrote:
On Wed, Feb 24, 2016 at 01:52:04PM +0100, Pino Toscano wrote:
> It eases the debugging, instead of getting just the name of the struct
> returned.
The series is fine, so ACK. Definitely improves the trace output :-)
Thanks -- I got tired of not seeing what was returned in case of
structs.
A few things that would be good though:
- Export the functions through the public API. We already have
functions to copy structs (eg. guestfs_copy_application,
guestfs_copy_application_list).
Would be actually worth exporting them for general usage, though?
I thought about this, and I did not find immediate use cases; although
I can change idea if there are enough/good ones.
After all, making the current functions public is trivial job once
there's the need for them.
- Provide another function for printing lists of structs too, so
you
don't need the loop for RStructList.
That would follow suit with the above: currently the loops for
RStructList is needed only in one (private) place.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)