Re: [Libguestfs] [PATCH] set-smp: only set smp value at config time

On Thu, Feb 23, 2012 at 05:15:24PM +0800, Wanlong Gao wrote: > On 02/23/2012 04:45 PM, Richard W.M. Jones wrote: > >> There are some problems with this patch, but mainly see >> my comments on this bug: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=796520 > > > Rich: > > Did you mean adding a ConfigOnly flag to each non-daemon-function? Yes, to all the ones in the first list: https://bugzilla.redhat.com/show_bug.cgi?id=796520#c2 so eg: - ("add_cdrom", (RErr, [String "filename"], []), -1, [DeprecatedBy "add_drive_opts"], + ("add_cdrom", (RErr, [String "filename"], []), -1, [DeprecatedBy "add_drive_opts"; ConfigOnly], and then of course the generator has to be changed.

Rich.