Re: [Libguestfs] [PATCH v6 5/7] New API: internal_yara_scan
On Thu, Apr 06, 2017 at 11:41:05PM +0300, Matteo Cafasso wrote:
+/* Has one FileOut parameter. */
+int
+do_internal_yara_scan (const char *path)
+{
+ int ret = 0;
Not returning 'ret', so call it something else, eg. 'r'.
There are further instances below.
The rest of the commit looks fine, so ACK with the changes.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top