Re: [Libguestfs] [PATCH 2/2] v2v: -i ova: Derive the name from the OVA filename.
On Friday, 9 September 2016 15:09:57 CEST Richard W.M. Jones wrote:
diff --git a/v2v/name_from_disk.ml b/v2v/name_from_disk.ml
index 73caf34..878b7c6 100644
--- a/v2v/name_from_disk.ml
+++ b/v2v/name_from_disk.ml
@@ -26,6 +26,7 @@ let name_from_disk disk =
let suffixes = [
".img"; ".qcow2"; ".raw"; ".vmdk";
"-sda";
+ ".ova";
Minor niptick: can you please move the ".ova" element in the first line
of suffixes, sorted up there? Eg
".img"; ".ova"; ".qcow2"; ".raw";
".vmdk";
LGTM otherwise.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)