Re: [Libguestfs] [PATCH 0/3] WIP readline escaping functions
Hi Maros,
On Friday 31 October 2014 18:18:13 mzatko(a)redhat.com wrote:
From: Maros Zatko <hacxman(a)gmail.com>
Auxiliary functions for readline to support space character escaping
in filenames in future.
Escaping function is taken from fish.c (used to be
parse_quoted_string) plus its un-escaping counterpart. There are a
few tests for both.
Maros Zatko (3):
fish: rl.{c,h} - escaping functions for readline
fish: basic tests for readline escaping
autotools: add fish/test
This looks like a good start in improving guestfish escaping/unescaping
functions. I have few general questions/notes:
- the two paragraph of descriptions above may better suited directly for
the patch adding rl.c/h
- given that rl.c seems extracted from guestfish, may be better to do
the "function extraction" in two steps: first move the functions from
fish.c in an own file (adding it to the build system, etc), and then
do the improvements on them. This way it is easier to track where they
came from, and making sure guestfish can still use them.
- most probably testquoting can just be directly in fish/test-quoting.c,
among the other tests
- take care of the indentation, like the space before a parenthesis
I'm adding few more specific notes/questions in patches.
--
Pino Toscano