Re: [Libguestfs] nbdkit rust plugin: copyright notices, Cargo workspace, and macro hygiene

I pushed 2 & 3, thanks. But ... > From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 > From: Alan Somers <asomers(a)gmail.com&gt; > Date: Mon, 15 Jun 2020 16:59:53 -0600 > Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory > > This is necessary for other Rust projects to depend on unrelesed > versions of the nbdkit crate. > --- > Cargo.toml | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 Cargo.toml > > diff --git a/Cargo.toml b/Cargo.toml > new file mode 100644 > index 00000000..f50a66b7 > --- /dev/null > +++ b/Cargo.toml > @@ -0,0 +1,2 @@ > +[workspace] > +members = ["plugins/rust"] Is it really absolutely necessary to have this in the top level directory of the source tree? Rich.