Re: [Libguestfs] [PATCH] java: support OpenJDK 10+
On Sun, May 06, 2018 at 04:11:36PM +0200, Hilko Bengen wrote:
* Pino Toscano:
> @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then
> AC_SUBST(JAR_INSTALL_DIR)
> AC_SUBST(JNI_INSTALL_DIR)
> AC_SUBST(JNI_VERSION_INFO)
> + AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"])
> fi
>
> AM_CONDITIONAL([HAVE_JAVA],[test "x$with_java" != "xno"
&& test -n "$JAVAC"])
The AM_CONDITIONAL must be moved outside the if ... fi shell
conditional, otherwise configure will fail if invoked with
--without-java.
Thanks hillu, would you mind just pushing a quick fix? Probably
easier than going through patch review for an obvious bug and I'm away
for the next week.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org