Re: [Libguestfs] [PATCH 0/2] bash-completion: Install symbolic links instead of copies of files (RHBZ#1156298).
On Fri, Oct 24, 2014 at 10:37:34AM +0200, Pino Toscano wrote:
On Friday 24 October 2014 09:14:29 Richard W.M. Jones wrote:
> Previously we copied the files instead of the symlinks.
This series LGTM.
On the other hand, given that the symlinks in the builddir are not used
at all, why not just create them only at install time?
I guess because it's nice to look at the build directory and have a
good idea what the install directory will look like, instead of having
to decode some shell script in the Makefile.
Also because (in some alternate universe) you could add bash
completion paths in './run'. This is not possible at the moment
however ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html