Re: [Libguestfs] --disable-appliance creates supermin.d files
On Thu, Aug 22, 2013 at 10:19:18AM +0200, Olaf Hering wrote:
On Thu, Aug 22, Richard W.M. Jones wrote:
> On Thu, Aug 22, 2013 at 09:28:36AM +0200, Olaf Hering wrote:
> > Why does the toplevel Makefile process appliance/, and creates
> > supermin.d during make install, whith configure --disable-appliance? I
> > have to double check what actually happens, it seems it causes startup
> > failures if the resulting binary packages are started on a host that
> > happens to have supermin installed.
What happens is that ext2_lookup fails for me. The package is build with
env \
QEMU=/usr/bin/qemu-kvm \
SUPERMIN=supermin \
SUPERMIN_HELPER=supermin-helper \
./configure --disable-appliance
So the question is: should --disable-appliance just not create the
appliance during "make", or should it also remove all supermin support
from the resulting binaries (by not creating supermin.d)?
[...]
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d
supermin helper [06632ms] visiting /usr/lib64/guestfs/supermin.d/daemon.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/init.img
supermin helper [06711ms] visiting /usr/lib64/guestfs/supermin.d/udev-rules.img
supermin-helper: ext2: parent directory not found: /lib: File not found by ext2_lookup
It looks as if base.img and hostfiles are not being created, but the
daemon.img (guestfsd), init.img (/init) and udev-rules.img files are
still being created, so essentially making a broken supermin image.
./configure --disable-appliance should probably skip the appliance
subdirectory (of the source) entirely, and it seems like it would fix
this problem.
Also of note:
Even if you use --disable-appliance, libguestfs is built with code to
handle supermin appliances (see src/appliance.c). If you don't want
to use supermin images at all (and no SuSE users wants to), it may be
a good idea to have a separate ./configure flag which disables this
code. OTOH this code won't do anything harmful by just being included.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW