Re: [Libguestfs] [PATCH v2 0/2] daemon: Move the useful 'is_zero' function into common code.
On Thu, Apr 20, 2017 at 02:30:52PM +0200, Pino Toscano wrote:
On Wednesday, 19 April 2017 18:46:37 CEST Richard W.M. Jones wrote:
> v1 -> v2:
>
> The first patch is the same (the pure refactoring), but in the second
> patch I implement Eric Blake's suggested version.
LGTM -- can you please add Eric's text to the comment of is_zero, so
it is easier to remember why the 16-bytes trick is done?
Done, thanks.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org