Re: [Libguestfs] [nbdkit PATCH] protocol: Trivially implement NBD_CMD_FLAG_DF

On Thu, Mar 28, 2019 at 10:44:42PM -0500, Eric Blake wrote: > The DF flag is only available to clients that negotiated structured > replies, and even then, the spec does not require that it be > implemented. However, since our current implementation can't fragment > NBD_CMD_READ replies, we trivially implement the flag (by ignoring > it); we don't even have to pass it on to the plugins. > > Enhance some documentation about sparse reads while at it (when we > finally do allow plugins to implement sparse reads, we'll have to pass > on the DF flag, as well as perform reassembly back into one reply > ourselves if the plugin ignored the flag). > > tests/test-eflags.sh can't really test this, as it requires the > negotiation of structured replies (which in turn requires newstyle, > not oldstyle...) > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; Looks good to me, so ACK.