Re: [Libguestfs] [libnbd PATCH] ocaml: map C's uint32_t to OCaml's int64
On Fri, Jan 14, 2022 at 02:38:33PM +0100, Laszlo Ersek wrote:
--- a/ocaml/examples/extents.ml
+++ b/ocaml/examples/extents.ml
@@ -20,14 +20,14 @@ let () =
if meta = "base:allocation" then (
printf "index\t%16s %16s %s\n" "offset"
"length" "flags";
for i = 0 to Array.length entries / 2 - 1 do
- let len = Int64.of_int32 entries.(i*2)
+ let len = entries.(i*2)
It actually improves the code, I wasn't expecting that :-)
This all looks great to me, ACK.
Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com>
I think you should be able to push it directly since you are
already a member of the libnbd project.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top