Re: [Libguestfs] [libnbd PATCH 16/18] tests/requires: wrap source code at 80 characters

>> snprintf (cmd, sizeof cmd, >> - "if %s --object tls-creds-x509,id=tls0 |& grep -sq 'TLS credentials support requires GNUTLS'; then exit 1; else exit 0; fi", >> + "if %s --object tls-creds-x509,id=tls0 \\\n" >> + " |& grep -sq 'TLS credentials support requires GNUTLS'\n" > > Note: |& is a bashism; but system() might not invoke bash. So this is > already non-portable code; and we should be fixing that. (I don't > mind doing it as a followup if you end up pushing before seeing this > message). I noticed |& too; my thought was "TIL". :) > >> + "then\n" >> + " exit 1\n" >> + "else\n" >> + " exit 0\n" >> + "fi\n", > > For that matter, 'if ...; then exit 1; else exit 0; fi' can be > compressed to '! ...'. > Yes, I noticed that too, but I assumed there was a finer point I was missing. :/