Re: [Libguestfs] [libnbd PATCH] Fix building with for ocaml < 4.06.0

On 6/12/19 6:27 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > > Notes: > This is the simplest solution suggested to me by Rich and it works. > > Most of autotools are not friends with me, so the other approach I tried, with > requiring at least OCaml 4.05.0, having this fix in only for OCaml < 4.06.0 and > properly detecting and reporting that, was a bit ugly. I prefer the lightweight approach - all the more configure.ac does is add the ability to do #ifdef-ery probing on things that don't originally come with enough #ifdef witnesses; but here, the absence of Bytes_val is all the more that you would probe for in configure.ac, making it not worth the effort to add yet another macro just to work around the problem. Which platform are you compiling on, and what OCaml version are you using? That said, I don't see any reason to not commit this patch.

-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org