Richard W.M. Jones wrote:
>From 77b9dc04cf336e751287837fa35390d875b22e4b Mon Sep 17 00:00:00
2001
From: Richard Jones <rjones(a)trick.home.annexia.org>
Date: Thu, 13 Aug 2009 14:41:52 +0100
Subject: [PATCH 5/7] Misc parameters which are String but should be Pathname.
---
src/generator.ml | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/generator.ml b/src/generator.ml
index 1278afd..b8f9ace 100755
--- a/src/generator.ml
+++ b/src/generator.ml
@@ -856,7 +856,7 @@ Note that this function cannot correctly handle binary files
as end of string). For those you need to use the C<guestfs_read_file>
or C<guestfs_download> functions which have a more complex interface.");
- ("ll", (RString "listing", [String "directory"]), 5,
[],
+ ("ll", (RString "listing", [Pathname "directory"]), 5,
[],
[], (* XXX Tricky to test because it depends on the exact format
* of the 'ls -l' command, which changes between F10 and F11.
*)
@@ -868,7 +868,7 @@ there is no cwd) in the format of 'ls -la'.
This command is mostly useful for interactive sessions. It
is I<not> intended that you try to parse the output string.");
- ("ls", (RStringList "listing", [String "directory"]), 6,
[],
+ ("ls", (RStringList "listing", [Pathname "directory"]),
6, [],
[InitBasicFS, Always, TestOutputList (
[["touch"; "/new"];
["touch"; "/newer"];
@@ -1910,7 +1910,7 @@ I<gzip compressed> tar file) into C<directory>.
To upload an uncompressed tarball, use C<guestfs_tar_in>.");
- ("tgz_out", (RErr, [String "directory"; FileOut
"tarball"]), 72, [],
+ ("tgz_out", (RErr, [Pathname "directory"; FileOut
"tarball"]), 72, [],
Looks fine. But why not do the same for tgz_in ?
ACK
[],
"pack directory into compressed tarball",
...