Re: [Libguestfs] [PATCH libnbd] golang/make-disst.sh: Remove the @v/list file

On Mon, Nov 08, 2021 at 08:28:38PM +0200, Nir Soffer wrote: > This file must list all the version on the server, not latest version. > It should be created on the server after uploading a new release. > > Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt; > --- > golang/make-dist.sh | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/golang/make-dist.sh b/golang/make-dist.sh > index 1aef36c..f728b1f 100755 > --- a/golang/make-dist.sh > +++ b/golang/make-dist.sh > @@ -93,6 +93,17 @@ rm -rf libguestfs.org > # ├── v1.11.4.mod > # └── v1.11.4.zip > # > +# We create @latest and @v/*{.info,mod,zip} here. > +# > +# The "@v/list" file must be created on the web server after uploading > +# a new release: > +# > +# $ cd libguestfs.org/libnbd/@v > +# $ ls -1 v*.info | awk -F.info '{print $1}' > list > +# $ cat list > +# v1.11.3 > +# v1.11.4 > +# > # See https://golang.org/ref/mod#serving-from-proxy > > module_dir=libguestfs.org/libnbd > @@ -103,12 +114,6 @@ mkdir -p $v_dir > echo "{\"Version\": \"$version\"}" > $module_dir/@latest > echo "{\"Version\": \"$version\"}" > $v_dir/$version.info > > -# This is not entirely correct. This file should have a list of all > -# versions available, here we create only single version. This should > -# really be done on the server by appending the new version to the > -# list file. > -echo $version > $v_dir/list > - > cp go.mod $v_dir/$version.mod > mv $version.zip $v_dir ACK