Re: [Libguestfs] [PATCH 1/2] Use gnulib set_nonblocking_flag function instead of fcntl.
On Friday, 3 March 2017 16:00:22 CET Richard W.M. Jones wrote:
The previous code:
fcntl (fd, F_SETFL, O_NONBLOCK)
was technically incorrect, because it would have reset any
other flags on the file descriptor.
Thanks: Eric Blake
---
The series LGTM.
As additional work for NONBLOCK, I'd use set_nonblocking_flag instead
of SOCK_NONBLOCK in the only usage of it in accept4, i.e.
lib/launch-libvirt.c, so we can get rid of one of the (IMHO) wrong
definitions for non-Linux added by commit
7ddf6bcbfdc66855b594afaaacdc4998177f2286.
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)