[Libguestfs] Rust Bindings for Libnbd
> +let hidden_handle_calls : NameSt.t = + NameSet.of_list + [
> "get_debug"; "set_debug"; "set_debug_callback";
> "clear_debug_callback" ]
So, hmm. Isn't it better to track this in the API.ml file?
Perhaps, but it is only specific to Rust, so I thought it was best
placed in the Rust.ml file.
> +(* Convert snake-case to upper camel-case. *)
In this comment, an example would help. eg:
(* Convert snake-case to upper camel-case. * For example: [get_debug
=> GetDebug] *)
Doesn't golang have a similar function? It does:
generator/Golang.ml: let camel_case name =
It would be better to extract this function into common code (eg.
into generator/utils.ml), as a separate patch.
Yes, I've made a new patch with the camel_case-function moved to
utils.ml.
I think I fixed most of your other comments as well.
Best regards,
Tage