Re: [Libguestfs] [p2v PATCH 4/4] Makefile.am: speed up the boot phase of the "virt-p2v in a VM" tests
On Tue, Aug 30, 2022 at 03:34:46PM +0200, Laszlo Ersek wrote:
On 08/30/22 15:11, Richard W.M. Jones wrote:
>
> Series looks good, thanks.
>
> Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com>
Thanks :)
Let me wait for Eric's next round of comments / answers though, before I
merge the series.
I think I've answered everything pending on the 'set -e' and
'#!/bin/bash -' questions. I'm not opposed to them going in as-is,
since it matches existing usage, and as long as we are aware of the
potential for pitfalls. Beyond that, I don't think I had any other
comments, so I'm okay if you are ready to merge.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org