Re: [Libguestfs] [PATCH libnbd 1/4] lib: Move nbd_aio_is_* function impls to separate source file.
On 6/5/19 6:15 AM, Richard W.M. Jones wrote:
Simple code motion.
---
lib/Makefile.am | 1 +
lib/aio.c | 78 -----------------------------------
lib/is-state.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 106 insertions(+), 78 deletions(-)
+++ b/lib/is-state.c
@@ -0,0 +1,105 @@
+#include <config.h>
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <inttypes.h>
Do you really need all of these? At least errno.h looks spurious after
a quick glance.
ACK.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)