Re: [Libguestfs] [v2v PATCH] nbdkit, qemuNBD: run_unix: formally require externally provided socket

On Wed, Mar 23, 2022 at 11:43:30AM +0100, Laszlo Ersek wrote: > At this point, virt-v2v never relies on the Unix domain sockets created > inside the "run_unix" implementations. Simplify the code by removing this > option. > > Consequently, the internally created temporary directory only holds the > NBD server's PID file, and never its UNIX domain socket. Therefore: > > (1) we no longer need the libguestfs socket dir to be our temp dir, > > (2) we need not change the file mode bits on the temp dir, > > (3) we can rename "tmpdir" to the more specific "piddir". > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2066773 > Signed-off-by: Laszlo Ersek <lersek(a)redhat.com&gt; ACK. I pushed my patch -- note it has changes related to the "lazy" clause relative to what I posted in v3. I also tested with your patch on top, doing both non-root and root conversions, and it all seems to work. Rich.