February 2025 - Libguestfs - libguestfs List Archives

nbdkit | Failed pipeline for master | 77c71135
by GitLab 11 Feb '25

11 Feb '25

Pipeline #1665618740 has failed! Project: nbdkit ( https://gitlab.com/nbdkit/nbdkit ) Branch: master ( https://gitlab.com/nbdkit/nbdkit/-/commits/master ) Commit: 77c71135 ( https://gitlab.com/nbdkit/nbdkit/-/commit/77c71135358b84ff72a55920ddea17112… ) Commit Message: ci: Update FreeBSD builds Rebuild ci/ director... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1665618740 ( https://gitlab.com/nbdkit/nbdkit/-/pipelines/1665618740 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9103157381 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9103157381/raw ) Stage: builds Name: x86_64-freebsd-current Job #9103157378 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9103157378/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9103157380 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9103157380/raw ) Stage: builds Name: x86_64-freebsd-14 -- You're receiving this email because of your account on gitlab.com.

1 0

nbdkit | Failed pipeline for master | 300943b8
by GitLab 11 Feb '25

11 Feb '25

Pipeline #1665416372 has failed! Project: nbdkit ( https://gitlab.com/nbdkit/nbdkit ) Branch: master ( https://gitlab.com/nbdkit/nbdkit/-/commits/master ) Commit: 300943b8 ( https://gitlab.com/nbdkit/nbdkit/-/commit/300943b8dec2eec7fb6a7ce550bbc4dd7… ) Commit Message: docs: Small revisions to the release notes Upd... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1665416372 ( https://gitlab.com/nbdkit/nbdkit/-/pipelines/1665416372 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9101708607 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9101708607/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9101708609 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9101708609/raw ) Stage: builds Name: x86_64-freebsd-14 Job #9101708611 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9101708611/raw ) Stage: builds Name: x86_64-freebsd-current -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 06349cde
by GitLab 11 Feb '25

11 Feb '25

Pipeline #1665416299 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 06349cde ( https://gitlab.com/nbdkit/libnbd/-/commit/06349cde1a9b344006b2749e80bf55e08… ) Commit Message: copy: Include pthread.h OpenBSD's clang requir... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1665416299 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/1665416299 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9101707957 ( https://gitlab.com/nbdkit/libnbd/-/jobs/9101707957/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9101707959 ( https://gitlab.com/nbdkit/libnbd/-/jobs/9101707959/raw ) Stage: builds Name: x86_64-freebsd-14 Job #9101707963 ( https://gitlab.com/nbdkit/libnbd/-/jobs/9101707963/raw ) Stage: builds Name: x86_64-freebsd-current -- You're receiving this email because of your account on gitlab.com.

1 0

[PATCH 0/2] convert: Use yum/apt/... for package removals
by Cole Robinson 10 Feb '25

10 Feb '25

https://issues.redhat.com/browse/RHEL-71522 Switch package removal from rpm/dep to yum/dnf/etc, to handle the case when other packages depend on ex. open-vm-tools Changes since RFC: + use cached `inspect` data -> fixes test suite + make failure non-fatal + ignore empty package list This may still break some really old cases. Notable `unconfigure_xen` has a comment referencing RHEL 3, which lacks yum AFAIK. Which would cause Guest_packages.uninstall_command to error. Maybe we don't care about RHEL-3? Or turn the error into a warning and be done with it? Cole Robinson (2): convert: Use yum/apt/... for package removals, not rpm/dpkg convert: make package removal failure non-fatal convert/convert_linux.ml | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) -- 2.48.1

2 5

[PATCH] WIP: convert: Use yum/apt/... for package removals, not rpm/dpkg
by Cole Robinson 10 Feb '25

10 Feb '25

Current package removal implementation uses `rpm -e`, which will fail if anything depends on the package we are trying to remove. Like when `spausedd` is dependent on `open-vm-tools`. Reuse the package uninstall logic from virt-customize, which will handle this no problem. Fixes: https://issues.redhat.com/browse/RHEL-71522 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- First time touching ocaml, be gentle :) This fixes my minimal test case, but there's test suite regressions. + How to run a single test against in tree virt-v2v? + and/or get `make check` to spit out more info? more questions: + uninstall failure is still fatal. example how to make this non-fatal? + `virt-v2v -v` logs don't show command stdout. expected? do I need an extra debug option? + better way to share code with customize_run.ml ? guest_pkgs_command() is lifted from there + should I instead change Linux.remove impl, or should I aim to remove that code entirely? convert/convert_linux.ml | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/convert/convert_linux.ml b/convert/convert_linux.ml index 3d0e2b88..2e0cf61b 100644 --- a/convert/convert_linux.ml +++ b/convert/convert_linux.ml @@ -131,6 +131,18 @@ let convert (g : G.guestfs) source inspect i_firmware _ keep_serial_console _ = (*----------------------------------------------------------------------*) (* Conversion step. *) + let guest_pkgs_command f = + try f (g#inspect_get_package_management inspect.i_root) with + | Guest_packages.Unknown_package_manager msg + | Guest_packages.Unimplemented_package_manager msg -> + error "%s" msg + in + + let uninstall_packages pkgs = + let cmd = guest_pkgs_command(Guest_packages.uninstall_command pkgs) in + ignore (g#sh cmd); + in + let rec do_convert () = augeas_grub_configuration (); @@ -237,7 +249,7 @@ let convert (g : G.guestfs) source inspect i_firmware _ keep_serial_console _ = else None ) inspect.i_apps in - Linux.remove g inspect.i_root xenmods; + uninstall_packages xenmods; (* Undo related nastiness if kmod-xenpv was installed. *) if xenmods <> [] then ( @@ -310,7 +322,7 @@ let convert (g : G.guestfs) source inspect i_firmware _ keep_serial_console _ = fun { G.app2_name = name } -> name = package_name ) inspect.i_apps in if has_guest_additions then - Linux.remove g inspect.i_root [package_name]; + uninstall_packages [package_name]; (* Guest Additions might have been installed from a tarball. The * above code won't detect this case. Look for the uninstall tool @@ -455,8 +467,7 @@ let convert (g : G.guestfs) source inspect i_firmware _ keep_serial_console _ = ) ); - let remove = !remove in - Linux.remove g inspect.i_root remove; + uninstall_packages !remove; (* VMware Tools may have been installed from a tarball, so the * above code won't remove it. Look for the uninstall tool and run @@ -503,7 +514,7 @@ let convert (g : G.guestfs) source inspect i_firmware _ keep_serial_console _ = let pkgs = List.map (fun { G.app2_name = name } -> name) pkgs in if pkgs <> [] then ( - Linux.remove g inspect.i_root pkgs; + uninstall_packages pkgs; (* Installing these guest utilities automatically unconfigures * ttys in /etc/inittab if the system uses it. We need to put -- 2.48.1

2 6

[PATCH 0/2] appliance: fix Debian dependencies
by da.gomez＠kernel.org 10 Feb '25

10 Feb '25

Add support for the new default DHCP client and fix sfdisk missing dependency. To: guestfs(a)lists.libguestfs.org Cc: da.gomez(a)samsung.com Signed-off-by: Daniel Gomez <da.gomez(a)samsung.com> --- Daniel Gomez (2): appliance: add dhcpcd support on Debian appliance: add support for sfdisk on Debian appliance/packagelist.in | 3 +++ 1 file changed, 3 insertions(+) --- base-commit: 0dee44bd369c59da2bd0aa531d98d96f619f428e change-id: 20250205-fix-debian-deps-8be4c30106c9 Best regards, -- Daniel Gomez <da.gomez(a)samsung.com>

3 4

libnbd 1.22 & nbdkit 1.42 preliminary release notes available
by Richard W.M. Jones 08 Feb '25

08 Feb '25

I'm planning to do libnbd & nbdkit stable releases during February. Preliminary release notes are available for feedback: https://gitlab.com/nbdkit/libnbd/-/blob/master/docs/libnbd-release-notes-1.… https://gitlab.com/nbdkit/nbdkit/-/blob/master/docs/nbdkit-release-notes-1.… Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

1 0

nbdkit | Failed pipeline for master | 1922e3be
by GitLab 07 Feb '25

07 Feb '25

Pipeline #1660956703 has failed! Project: nbdkit ( https://gitlab.com/nbdkit/nbdkit ) Branch: master ( https://gitlab.com/nbdkit/nbdkit/-/commits/master ) Commit: 1922e3be ( https://gitlab.com/nbdkit/nbdkit/-/commit/1922e3beea79c2aa5bee5e34ece4e6aea… ) Commit Message: docs: Add outline release notes for nbdkit 1.42 Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1660956703 ( https://gitlab.com/nbdkit/nbdkit/-/pipelines/1660956703 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9076113916 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9076113916/raw ) Stage: builds Name: x86_64-freebsd-14 Job #9076113915 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9076113915/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9076113919 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9076113919/raw ) Stage: builds Name: x86_64-freebsd-current -- You're receiving this email because of your account on gitlab.com.

1 0

nbdkit | Failed pipeline for master | 944934f1
by GitLab 07 Feb '25

07 Feb '25

Pipeline #1660404655 has failed! Project: nbdkit ( https://gitlab.com/nbdkit/nbdkit ) Branch: master ( https://gitlab.com/nbdkit/nbdkit/-/commits/master ) Commit: 944934f1 ( https://gitlab.com/nbdkit/nbdkit/-/commit/944934f11e5536bb344dd868cc4ebbed9… ) Commit Message: Revert "build: Disable -Wunused-command-line-ar... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1660404655 ( https://gitlab.com/nbdkit/nbdkit/-/pipelines/1660404655 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9072113797 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9072113797/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9072113799 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9072113799/raw ) Stage: builds Name: x86_64-freebsd-14 Job #9072113800 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9072113800/raw ) Stage: builds Name: x86_64-freebsd-current -- You're receiving this email because of your account on gitlab.com.

1 0

nbdkit | Failed pipeline for master | e6f5871a
by GitLab 07 Feb '25

07 Feb '25

Pipeline #1660369930 has failed! Project: nbdkit ( https://gitlab.com/nbdkit/nbdkit ) Branch: master ( https://gitlab.com/nbdkit/nbdkit/-/commits/master ) Commit: e6f5871a ( https://gitlab.com/nbdkit/nbdkit/-/commit/e6f5871a783b3787d48ca1f4396a5fd42… ) Commit Message: Merge branch '2025-freebsd-clang-no-warning' in... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #1660369930 ( https://gitlab.com/nbdkit/nbdkit/-/pipelines/1660369930 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 3 failed jobs. Job #9071851654 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9071851654/raw ) Stage: builds Name: x86_64-freebsd-current Job #9071851648 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9071851648/raw ) Stage: builds Name: x86_64-freebsd-13 Job #9071851651 ( https://gitlab.com/nbdkit/nbdkit/-/jobs/9071851651/raw ) Stage: builds Name: x86_64-freebsd-14 -- You're receiving this email because of your account on gitlab.com.

1 0