[PATCH 0/2] appliance: fix Debian dependencies
Add support for the new default DHCP client and fix sfdisk missing dependency. To: guestfs@lists.libguestfs.org Cc: da.gomez@samsung.com Signed-off-by: Daniel Gomez <da.gomez@samsung.com> --- Daniel Gomez (2): appliance: add dhcpcd support on Debian appliance: add support for sfdisk on Debian appliance/packagelist.in | 3 +++ 1 file changed, 3 insertions(+) --- base-commit: 0dee44bd369c59da2bd0aa531d98d96f619f428e change-id: 20250205-fix-debian-deps-8be4c30106c9 Best regards, -- Daniel Gomez <da.gomez@samsung.com>
From: Daniel Gomez <da.gomez@samsung.com> Debian has replaced the deprecated isc-dhcp-client (dhclient) with dhcpcd-base (dhcpcd) as the default DHCP client [1]. This causes network issues in virt-builder since isc-dhcp-client is no longer installed by default. Add support for dhcpcd (dhcpcd-base package) in Debian. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041066 Signed-off-by: Daniel Gomez <da.gomez@samsung.com> --- appliance/packagelist.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 7b6e9f23f3c15c964a2f126478206d496928e29b..2062f20bb712c194a88757dc0dc0b592dc0a9479 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -74,7 +74,9 @@ dnl iproute has been renamed to iproute2 iputils-ping iputils-arping iputils-tracepath +dnl isc-dhcp-client has been replaced with dhcpcd-base isc-dhcp-client + dhcpcd-base ldmtool libc-bin librpm9 -- 2.47.2
From: Daniel Gomez <da.gomez@samsung.com> Fixes virt-builder error: virt-builder: error: libguestfs error: inspect_os: execvp: sfdisk: No such file or directory Signed-off-by: Daniel Gomez <da.gomez@samsung.com> --- appliance/packagelist.in | 1 + 1 file changed, 1 insertion(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 2062f20bb712c194a88757dc0dc0b592dc0a9479..854d254c64514c92505c324cdb71295820e022d1 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -62,6 +62,7 @@ dnl old name used in Jessie and earlier cryptsetup dash extlinux + fdisk dnl gfs-tools, gfs2-tools have been renamed to gfs2-utils gfs-tools gfs2-tools -- 2.47.2
Thanks, those are upstream in 2c6fb596b7..82e2dea96a I didn't make any change to your patch, but note that it's possible to list both old & new packages in appliance/packagelist.in. supermin (which processes that file) will just ignore any system packages that don't exist. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit
On Thu, Feb 06, 2025 at 08:27:58AM +0100, Richard W.M. Jones wrote:
Thanks, those are upstream in 2c6fb596b7..82e2dea96a
I didn't make any change to your patch, but note that it's possible to list both old & new packages in appliance/packagelist.in. supermin (which processes that file) will just ignore any system packages that don't exist.
Thanks for letting me know. Regarding the dhcp client, both packages (isc-dhcp-client and dhcpcd-base) are kept. Debian testing defaults to dhcpcd-base but it is still possible for users to use isc-dhcp-client if they install it manually. With current Debian libguestfs package, installing isc-dhcp-client is the only way to make network work when virt-builder is used.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit
participants (3)
-
da.gomez＠kernel.org -
Daniel Gomez
-
Richard W.M. Jones