October 2023 - Libguestfs - libguestfs List Archives

A note on migration of this list to lists.libguestfs.org
by Richard W.M. Jones 18 Oct '23

18 Oct '23

We will soon be migrating this list over to a new hosting service at lists.libguestfs.org. All subscriptions will be moved automatically. The main visible change will be that the email address of the list will be different (since we will not longer be allowed to use the @redhat.com address). I'll have more details later. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

1 0

[nbdkit] Two POSIX questions for you ...
by Richard W.M. Jones 16 Oct '23

16 Oct '23

Hi Eric, a couple of POSIX questions for you from nbdkit. The first question is from an AUR comment on nbdkit: https://aur.archlinux.org/packages/nbdkit#comment-937381 I think there's a bash-ism in the logscript parameter in this test: https://gitlab.com/nbdkit/nbdkit/-/blame/master/tests/test-log-script-info.… I believe it is happening in the $(( .. )) expression. How do we write that so it'll work in a posix shell? - - - Secondly while looking into this I was trying variations on: $ POSIXLY_CORRECT=1 ./nbdkit -fv data '1 2 3' --run 'nbdinfo $uri' This doesn't actually cause bash to emulate a posix shell, but it does uncover a different bug: nbdkit: error: raw|base64|data parameter must be specified exactly once This seems to be happening because getopt_long in wrapper.c behaves somehow differently parsing when POSIXLY_CORRECT is set. However I couldn't work out exactly why. https://gitlab.com/nbdkit/nbdkit/-/blob/master/wrapper.c?ref_type=heads#L278 I guess the wrapper ought to work if POSIXLY_CORRECT is set (?) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit

3 9

Reported issues in nbdkit_parse_probability (was: Fwd: AUR Comment for nbdkit)
by Richard W.M. Jones 14 Oct '23

14 Oct '23

https://aur.archlinux.org/packages/nbdkit#comment-938282 ----- Forwarded message from notify(a)aur.archlinux.org ----- Date: Sat, 14 Oct 2023 12:40:02 +0000 Subject: AUR Comment for nbdkit dreieck [1] added the following comment to nbdkit [2]: `check()` fails for me, too: ``` [...] make check-TESTS make[3]: Entering directory '/tmp/makepkg/build/nbdkit/src/nbdkit-1.36.0/server' make[4]: Entering directory '/tmp/makepkg/build/nbdkit/src/nbdkit-1.36.0/server' FAIL: test-public ============================================================================ Testsuite summary for nbdkit 1.36.0 ============================================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See server/test-suite.log ============================================================================ ``` `server/test-suite.log`: ``` ========================================== nbdkit 1.36.0: server/test-suite.log ========================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test-public ================= Wrong return value for inf, got 0, expected -1 Wrong result for inf, got inf, expected 0 Wrong return value for nan, got 0, expected -1 Wrong return value for nan/inf, got 0, expected -1 Wrong return value for inf/inf, got 0, expected -1 Wrong return value for nan/nan, got 0, expected -1 Wrong return value for -0, got 0, expected -1 Wrong return value for 1e200/1e-200, got 0, expected -1 Wrong result for 1e200/1e-200, got inf, expected 0 FAIL test-public (exit status: 1) ``` Regards! -- If you no longer wish to receive notifications about this package, please go to the package page [2] and select "Disable notifications". [1] https://aur.archlinux.org/account/dreieck/ [2] https://aur.archlinux.org/pkgbase/nbdkit/ ----- End forwarded message ----- -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

1 1

Fwd: virt-v2v creating image that does not install guest agent on first boot
by Richard W.M. Jones 07 Oct '23

07 Oct '23

This message got caught in moderation because the attachment was large. I put the attachment here: http://oirase.annexia.org/tmp/2023-lgarrett-virt-v2v-debug-output.txt ----- Forwarded message from Lee Garrett <lgarrett(a)rocketjump.eu> ----- Date: Sun, 10 Sep 2023 00:09:17 +0200 From: Lee Garrett <lgarrett(a)rocketjump.eu> To: libguestfs(a)redhat.com Subject: virt-v2v creating image that does not install guest agent on first boot Hi, rwmjones from #guestfs on libera IRC pointed me to this mail address. I've noticed that converting the latest Windows 11 trial image via virt-v2v does not install the guest agent any more on first boot. I have let the machine settle for ~10 minutes to ensure it's not just because I'm too impatient. I can see C:\qemu-ga-x86-64.msi, and also a bunch of files in "C:\Program Files\Guestfs\Firstboot\" and .\Scripts, so the files are definitely copied onto the VM image, just not executed for some reason. The vmware image was downloaded from https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/. The issue should be 100% reproducible (at least for me). I recall that an older image from two, three weeks ago downloaded from the same location did not have this issue. There guest agent was installed and working on the first boot. Unfortunately I overwrote the image so I cannot verify this. I have attached the debug output of the virt-v2v run of the latest image where this issue is apparent (guest agent not being installed). Please let me know if there's anything else I can check, or if you need any further info. Cheers, Lee ----- End forwarded message ----- -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org

5 32

Some comments on the libnbd apk in Alpine
by Richard W.M. Jones 06 Oct '23

06 Oct '23

Hi Sean, the maintainers of libnbd here. Thanks for packaging libnbd in Alpine: https://git.alpinelinux.org/aports/tree/testing/libnbd/APKBUILD I have a few comments: (1) The url field should be "https://gitlab.com/nbdkit/libnbd" (The one you are using is an old, stale mirror) (2) libxml2-dev is not listed as a dependency. We had a request from an Alpine user to add this dependency because it enables several important features in libnbd, namely NBD URI support and some utilities which require URI support. It shouldn't be too much trouble to add since it appears that libxml2 is already built in Alpine. (3) libnbd 1.18 (next stable) will be released in a week or two: https://listman.redhat.com/archives/libguestfs/2023-September/032590.html If you have any questions or comments about the package you can send them to me and/or the mailing list (without subscribing if you don't want to). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

2 4

[PATCH libnbd 0/5] copy: Allow human sizes for --queue-size, etc
by Richard W.M. Jones 06 Oct '23

06 Oct '23

See companion patch: Subject: [PATCH nbdkit] server: Move size parsing code (nbdkit_parse_size) to common/include This is the second part of the patch. It adds the new human_size_parse function to libnbd and then uses it for parsing --queue-size, --request-size and --sparse. The main complication here is that there was already a common/utils/human-size.h header which ends up (eventually) being combined with the new header, but the process to get there and ensure that git bisection works is lengthy. Eventually we can copy the new, combined "human-size.h" back to nbdkit, but I didn't add that yet. Rich.

3 13

[PATCH v7 00/12] NBD 64-bit extensions for qemu
by Eric Blake 05 Oct '23

05 Oct '23

v6 was here: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg05231.html Since then: - patches v6 1-5 included in pull request - patch v6 6 logic improved, now v7 patch 1 - rebased to master Still needing review: - patch 1,6,7,11,12 Eric Blake (12): nbd/server: Support a request payload nbd/server: Prepare to receive extended header requests nbd/server: Prepare to send extended header replies nbd/server: Support 64-bit block status nbd/server: Enable initial support for extended headers nbd/client: Plumb errp through nbd_receive_replies nbd/client: Initial support for extended headers nbd/client: Accept 64-bit block status chunks nbd/client: Request extended headers during negotiation nbd/server: Refactor list of negotiated meta contexts nbd/server: Prepare for per-request filtering of BLOCK_STATUS nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS docs/interop/nbd.txt | 1 + include/block/nbd.h | 5 +- nbd/nbd-internal.h | 5 +- block/nbd.c | 67 ++- nbd/client-connection.c | 2 +- nbd/client.c | 124 ++++-- nbd/server.c | 418 ++++++++++++++---- qemu-nbd.c | 4 + block/trace-events | 1 + nbd/trace-events | 5 +- tests/qemu-iotests/223.out | 18 +- tests/qemu-iotests/233.out | 4 + tests/qemu-iotests/241.out | 3 + tests/qemu-iotests/307.out | 15 +- .../tests/nbd-qemu-allocation.out | 3 +- 15 files changed, 516 insertions(+), 159 deletions(-) -- 2.41.0

2 29

[PATCH virt-v2v] -it ssh: Double quote ssh command which tests remote file exists
by Richard W.M. Jones 02 Oct '23

02 Oct '23

Double quoting was removed in commit e2af12ba69c4463bb73d30db63290a887cdd41eb ("input: -i vmx: Remove support for openssh scp < 8.8", Nov 2021). However it should only have been removed from scp commands, not for this ssh command where it is still required. See: https://github.com/libguestfs/virt-v2v/issues/35 Thanks: Laszlo Ersek for diagnosis and suggesting the fix Reported-by: Bill Sanders --- input/parse_domain_from_vmx.ml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/input/parse_domain_from_vmx.ml b/input/parse_domain_from_vmx.ml index 15ee093f59..2e75e78506 100644 --- a/input/parse_domain_from_vmx.ml +++ b/input/parse_domain_from_vmx.ml @@ -97,7 +97,11 @@ let remote_file_exists uri path = | None -> "" | Some user -> quote user ^ "@") (quote (server_of_uri uri)) - (quote path) in + (* Double quoting is necessary for 'ssh', first to protect + * from the local shell, second to protect from the remote + * shell. https://github.com/libguestfs/virt-v2v/issues/35#issuecomment-1741730963 + *) + (quote (quote path)) in if verbose () then eprintf "%s\n%!" cmd; Sys.command cmd = 0 -- 2.41.0

2 2