July 2022 - Libguestfs - libguestfs List Archives

libnbd | Failed pipeline for master | bd3ea612
by GitLab 27 Jul '22

27 Jul '22

Pipeline #598419956 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: bd3ea612 ( https://gitlab.com/nbdkit/libnbd/-/commit/bd3ea612960445671e62250a238ecb9ab… ) Commit Message: lib/crypto.c: Check for <gnutls/socket.h> befor... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #598419956 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/598419956 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 4 failed jobs. Job #2778770472 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2778770472/raw ) Stage: builds Name: x86_64-freebsd-current Job #2778770469 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2778770469/raw ) Stage: builds Name: x86_64-freebsd-13 Job #2778770453 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2778770453/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2778770468 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2778770468/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 355049d8
by GitLab 27 Jul '22

27 Jul '22

Pipeline #598184886 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 355049d8 ( https://gitlab.com/nbdkit/libnbd/-/commit/355049d89e4ab96803dc21268ada9ba55… ) Commit Message: Version 1.13.8. Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #598184886 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/598184886 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #2777402509 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777402509/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2777402522 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777402522/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 9d5d5ee2
by GitLab 27 Jul '22

27 Jul '22

Pipeline #598171647 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9d5d5ee2 ( https://gitlab.com/nbdkit/libnbd/-/commit/9d5d5ee2f785421785f94606bb045bd52… ) Commit Message: generator: Add README.state-machine.md to EXTRA... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #598171647 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/598171647 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 2 failed jobs. Job #2777326781 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777326781/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2777326792 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777326792/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 39afa21c
by GitLab 27 Jul '22

27 Jul '22

Pipeline #598147373 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 39afa21c ( https://gitlab.com/nbdkit/libnbd/-/commit/39afa21c22ef2c49f9e039e4c7014c926… ) Commit Message: generator: Fix reentry to REPLY.START when recv... Commit Author: Richard W_M_ Jones ( https://gitlab.com/rwmjones ) Pipeline #598147373 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/598147373 ) triggered by Richard W_M_ Jones ( https://gitlab.com/rwmjones ) had 19 failed jobs. Job #2777192684 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192684/raw ) Stage: builds Name: i686-debian-11 Job #2777192682 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192682/raw ) Stage: builds Name: i686-debian-10 Job #2777192650 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192650/raw ) Stage: builds Name: x86_64-almalinux-8-clang Job #2777192646 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192646/raw ) Stage: builds Name: x86_64-almalinux-8 Job #2777192663 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192663/raw ) Stage: builds Name: x86_64-debian-sid Job #2777192679 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192679/raw ) Stage: builds Name: x86_64-ubuntu-1804 Job #2777192661 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192661/raw ) Stage: builds Name: x86_64-debian-11 Job #2777192654 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192654/raw ) Stage: builds Name: x86_64-alpine-edge Job #2777192675 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192675/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2777192685 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192685/raw ) Stage: builds Name: x86_64-freebsd-12 Job #2777192672 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192672/raw ) Stage: builds Name: x86_64-fedora-rawhide-clang Job #2777192657 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192657/raw ) Stage: builds Name: x86_64-centos-stream-8 Job #2777192666 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192666/raw ) Stage: builds Name: x86_64-fedora-36 Job #2777192659 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192659/raw ) Stage: builds Name: x86_64-debian-10 Job #2777192680 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192680/raw ) Stage: builds Name: x86_64-ubuntu-2004 Job #2777192664 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192664/raw ) Stage: builds Name: x86_64-fedora-35 Job #2777192669 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192669/raw ) Stage: builds Name: x86_64-fedora-rawhide Job #2777192677 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192677/raw ) Stage: builds Name: x86_64-opensuse-tumbleweed Job #2777192643 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2777192643/raw ) Stage: builds Name: x86_64-alpine-314 -- You're receiving this email because of your account on gitlab.com.

1 0

[nbdkit PATCH] tests: Better quoting for cleanup_fn
by Eric Blake 26 Jul '22

26 Jul '22

Testing with: === #!/bin/bash . tests/functions.sh cleanup_fn echo 'a b' cleanup_fn echo 'c d' === gives output: === a b c d === That is, our commands were munged by IFS splitting, because we stored commands in a flat variable. Fix it by instead using an array variable per cleanup_fn invocation. This does not fix the issue that commands are run in FIFO order; the comments in the recent test-nbd-client.sh mention that reverse order might be nicer, however, our existing kill_nbdkit() function assumes that it can call cleanup_fn during an existing cleanup function and that such cleanups will still be reached. Running cleanups in reverse order from the top level while still allowing multiple rounds of cleanup once cleanup is started is harder to achieve. --- If we like this, I'll apply the same patch to libnbd. Running the cleanups in reverse order is a tougher nut to crack; the nbdkit testsuite passed 'make check' when I did that (basically, swap the iteration of the for loop over _i in _run_cleanup_hooks), but that only tests the success paths, and it is the failure path of kill_nbdkit() where sane semantics are harder to guarantee with reverse ordering. tests/functions.sh.in | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/functions.sh.in b/tests/functions.sh.in index 6c5c481a..82f284a7 100644 --- a/tests/functions.sh.in +++ b/tests/functions.sh.in @@ -65,15 +65,18 @@ largest_qemu_disk=9223372035781033984 # # Run the command ‘cmd [args]’ when the test script exits. This is # run in all cases when the script exits, so is a reliable way to -# clean up test files, external processes etc. +# clean up test files, external processes etc. Cleanup hooks are run +# in the order of registration. # # Examples: # cleanup_fn rm -f test.out # cleanup_fn kill $pid -declare -a _cleanup_hook +_cleanup_hook_count=0 cleanup_fn () { - _cleanup_hook[${#_cleanup_hook[@]}]="$@" + local _hook=_cleanup_hook$((_cleanup_hook_count++)) + declare -ag $_hook + eval "$_hook=(\"\$@\")" } _run_cleanup_hooks () @@ -84,8 +87,9 @@ _run_cleanup_hooks () trap '' INT QUIT TERM EXIT ERR echo $0: run cleanup hooks: exit code $_status - for (( _i = 0; _i < ${#_cleanup_hook[@]}; ++_i )); do - ${_cleanup_hook[_i]} + for (( _i = 0; _i < $_cleanup_hook_count; ++_i )); do + local -n _hook=_cleanup_hook$_i + "${_hook[@]}" done exit $_status -- 2.37.1

3 11

libnbd | Failed pipeline for master | 612cfb2b
by GitLab 26 Jul '22

26 Jul '22

Pipeline #597118107 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 612cfb2b ( https://gitlab.com/nbdkit/libnbd/-/commit/612cfb2b6349e057d4219ad1b35086f83… ) Commit Message: tests: Avoid bash namerefs, for RHEL 7 RHEL 7 ... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #597118107 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/597118107 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2771460383 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2771460383/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2771460396 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2771460396/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

libnbd | Failed pipeline for master | 0cf89848
by GitLab 25 Jul '22

25 Jul '22

Pipeline #596188881 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 0cf89848 ( https://gitlab.com/nbdkit/libnbd/-/commit/0cf89848819ade7595f5006c8e967e84a… ) Commit Message: tests: Better quoting for cleanup_fn Testing w... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #596188881 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/596188881 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 2 failed jobs. Job #2766462614 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2766462614/raw ) Stage: builds Name: x86_64-opensuse-leap-153 Job #2766462621 ( https://gitlab.com/nbdkit/libnbd/-/jobs/2766462621/raw ) Stage: builds Name: x86_64-freebsd-12 -- You're receiving this email because of your account on gitlab.com.

1 0

[v2v PATCH v2] output/create_libvirt_xml: relax VCPU feature checking for "qemu64"
by Laszlo Ersek 22 Jul '22

22 Jul '22

When the source domain doesn't specify a VCPU model ("s_cpu_model" is None), and the guest OS is assumed to work with the default VCPU model ("gcaps_default_cpu" is true), we don't output any <cpu> element. In that case, libvirtd augments the domain config with: [1] <cpu mode='custom' match='exact' check='none'> <model fallback='forbid'>qemu64</model> </cpu> where the @check='none' attribute ensures that the converted domain will be launched, for example, on an Intel host, despite the "qemu64" VCPU model containing AMD-only feature flags such as "svm". However, if the source domain explicitly specifies the "qemu64" model (mostly seen with "-i libvirt -ic qemu://..."), we presently output [2] <cpu match='minimum'> <model fallback='allow'>qemu64</model> </cpu> which libvirtd completes as [3] <cpu mode='custom' match='minimum' check='partial'> <model fallback='allow'>qemu64</model> </cpu> In [3], cpu/@match='minimum' and cpu/model/@fallback='allow' are both laxer than @match='exact' and @fallback='forbid', respectively, in [1]. However, cpu/@check='partial' in [3] is stricter than @check='none' in [1]; it causes libvirtd to catch the "svm" feature flag on an Intel host, and prevents the converted domain from starting. The "qemu64" VCPU model is supposed to run on every possible host <https://gitlab.com/qemu-project/qemu/-/blob/master/docs/system/cpu-models-x…>, therefore make an exception for the explicitly specified "qemu64" VCPU model, and generate the @check='none' attribute. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2107503 Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> --- Notes: v2: - make the attribute dependent on "qemu64" [Rich] - retrofit the commit message v1: - https://listman.redhat.com/archives/libguestfs/2022-July/029504.html output/create_libvirt_xml.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/output/create_libvirt_xml.ml b/output/create_libvirt_xml.ml index 531a4f75bf3e..bd01304df674 100644 --- a/output/create_libvirt_xml.ml +++ b/output/create_libvirt_xml.ml @@ -192,6 +192,8 @@ let create_libvirt_xml ?pool source inspect List.push_back cpu_attrs ("mode", "host-passthrough"); | Some model -> List.push_back cpu_attrs ("match", "minimum"); + if model = "qemu64" then + List.push_back cpu_attrs ("check", "none"); (match source.s_cpu_vendor with | None -> () | Some vendor -> -- 2.19.1.3.g30247aa5d201

2 2

[v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute
by Laszlo Ersek 22 Jul '22

22 Jul '22

We currently don't generate any @check attribute for the /domain/cpu element, which causes the following libvirtd behavior <https://libvirt.org/formatdomain.html#cpu-model-and-topology>: > Once the domain starts, libvirt will automatically change the check > attribute to the best supported value to ensure the virtual CPU does not > change when the domain is migrated to another host Vera Wu reports that in practice, at least when the source CPU model is explicitly "qemu64", libvirtd sets @check='partial'. That's defined as: > Libvirt will check the guest CPU specification before starting a domain This is a problem: the default "qemu64" CPU model exposes the SVM CPU flag, and that's unsupportable on Intel hosts. SVM is the AMD counterpart of VT-x; IOW, the flag effectively advertizes AMD-specific nesting to guests. With @check='partial', libvirt prevents the converted domain from starting on Intel hosts; but with @check='none', > Libvirt does no checking and it is up to the hypervisor to refuse to > start the domain if it cannot provide the requested CPU. With QEMU this > means no checking is done at all since the default behavior of QEMU is > to emit warnings, but start the domain anyway. We don't care about the migratability of the converted domain, so relax the libvirtd checks, by generating the @check='none' attribute. Consider adding @check='none' in two cases: (1) When the source domain specifies a CPU model. Generating @check='none' in this case fixes the issue reported by Vera. (2) When the source domain does not specify a CPU model, and the guest OS is assumed to work well with the default CPU model. Generating @check='none' in this case is actually a no-op. Going from "no CPU element" to "<cpu check='none'/>" does not change how libvirtd augments the domain config. Namely, (2.1) for x86 guests, we get <cpu mode='custom' match='exact' check='none'> <model fallback='forbid'>qemu64</model> </cpu> either way, (2.2) for aarch64 guests, we get <cpu mode='custom' match='exact' check='none'> <model fallback='forbid'>cortex-a15</model> </cpu> either way. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2107503 Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> --- output/create_libvirt_xml.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/output/create_libvirt_xml.ml b/output/create_libvirt_xml.ml index 531a4f75bf3e..0343d3194268 100644 --- a/output/create_libvirt_xml.ml +++ b/output/create_libvirt_xml.ml @@ -192,6 +192,7 @@ let create_libvirt_xml ?pool source inspect List.push_back cpu_attrs ("mode", "host-passthrough"); | Some model -> List.push_back cpu_attrs ("match", "minimum"); + List.push_back cpu_attrs ("check", "none"); (match source.s_cpu_vendor with | None -> () | Some vendor -> -- 2.19.1.3.g30247aa5d201

3 8

[p2v PATCH] virt-p2v-make-*.in: make @datadir@ and @libdir@ resolvable
by Laszlo Ersek 21 Jul '22

21 Jul '22

./configure expands @datadir@ and @libdir@ to "${prefix}/share" and "${exec_prefix}/lib" by default (verbatim); $prefix and $exec_prefix are supposed to be substituted by the shell when the generated shell scripts are executed. For this, capture the prefix and exec_prefix values at the time ./configure runs. This fixes failures such as > $ virt-p2v-make-kickstart fedora > base64: /share/virt-p2v/issue: No such file or directory for such scripts that were installed with "make install". Note that the patch does not help when running virt-p2v-make-* from a git checkout that was just built, such as > $ ./virt-p2v-make-kickstart fedora In that case, VIRT_P2V_DATA_DIR still needs to be set to $PWD, as there is no "share" subdirectory in the checkout. Suggested-by: Richard W.M. Jones <rjones(a)redhat.com> Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> --- virt-p2v-make-disk.in | 2 ++ virt-p2v-make-kickstart.in | 2 ++ virt-p2v-make-kiwi.in | 2 ++ 3 files changed, 6 insertions(+) diff --git a/virt-p2v-make-disk.in b/virt-p2v-make-disk.in index ac477eb39be8..218ff1531872 100644 --- a/virt-p2v-make-disk.in +++ b/virt-p2v-make-disk.in @@ -20,6 +20,8 @@ unset CDPATH program="virt-p2v-make-disk" version="@PACKAGE_VERSION@" +prefix="@prefix@" +exec_prefix="@exec_prefix@" if [ -n "$VIRT_P2V_DATA_DIR" ]; then datadir="$VIRT_P2V_DATA_DIR" diff --git a/virt-p2v-make-kickstart.in b/virt-p2v-make-kickstart.in index d139c9bb554b..1706102d05c7 100644 --- a/virt-p2v-make-kickstart.in +++ b/virt-p2v-make-kickstart.in @@ -20,6 +20,8 @@ unset CDPATH program="virt-p2v-make-kickstart" version="@PACKAGE_VERSION@" +prefix="@prefix@" +exec_prefix="@exec_prefix@" # Parse the command line arguments. shortopts=o:vV diff --git a/virt-p2v-make-kiwi.in b/virt-p2v-make-kiwi.in index 987de11b54aa..a648f6a3886c 100644 --- a/virt-p2v-make-kiwi.in +++ b/virt-p2v-make-kiwi.in @@ -20,6 +20,8 @@ unset CDPATH program="virt-p2v-make-kiwi" version="@PACKAGE_VERSION@" +prefix="@prefix@" +exec_prefix="@exec_prefix@" # Parse the command line arguments. shortopts=o:V -- 2.19.1.3.g30247aa5d201

3 3