[libnbd PATCH 0/2] Fix test 505
by Eric Blake
Rich found that I had been using bogus logic, but it was hidden by
other bugs in our language bindings until recently.
Eric Blake (2):
python: Fix test 505
ocaml: Fix test 505
python/t/505-aio-pread-callback.py | 14 +++++++-------
.../test_505_aio_pread_structured_callback.ml | 14 +++++++-------
2 files changed, 14 insertions(+), 14 deletions(-)
--
2.20.1
4 years, 9 months
[libnbd PATCH 0/2] Drop generated file from git
by Eric Blake
Rich recently patched things to generate one man page per function
rather than libnbd-api.3 (nice), but in doing so got stumped by a
problem with a fresh git clone (automake fails for any 'include'
directive that does not already exist). I've figured out how to hack
around it, but the hack requires GNU make. We already use GNU make
constructs elsewhere (such as $(wildcard)), but while existing uses
are out of laziness and can probably be rewritten in portable make if
someone complained, this patch series cements our dependency on GNU
make (I don't know of any way to fix this problem for non-GNU make).
Hence I'm posting this for review, even though I think it's good to
go.
Eric Blake (2):
docs: Simplify generated docs/Makefile.inc
docs: Drop docs/Makefile.inc from git
docs/Makefile.am | 19 +-
docs/Makefile.inc | 633 --------------------------------------------
generator/generator | 42 +--
.gitignore | 1 +
4 files changed, 25 insertions(+), 670 deletions(-)
delete mode 100644 docs/Makefile.inc
--
2.20.1
4 years, 9 months
[nbdkit PATCH 0/2] more fast zero prep
by Eric Blake
Another couple things I noticed that are worth improving, but aren't
strictly related to implementing fast zero support.
Eric Blake (2):
server: Assert sane error responses
nozero: More efficient FUA handling
filters/nozero/nozero.c | 17 +++++++++++--
server/filters.c | 56 +++++++++++++++++++++++++++++++++--------
server/protocol.c | 32 +++++++++++++++++------
3 files changed, 84 insertions(+), 21 deletions(-)
--
2.20.1
4 years, 9 months
[PATCH 0/6] Implement OClosure.
by Richard W.M. Jones
Patches 1-4 are basically uncontroversial, straightforward refactoring
and IMHO we should just push them. Possibly 1-3 should be squashed
together, but I posted them separately so they are easier to review.
Patches 5 and 6 together implement OClosure. Patch 5 adds the feature
and is simple to understand.
Patch 6 changes the Closure completion callbacks into OClosure, but
because it doesn't change the position within the list of arguments
the C API doesn't change at all. The Python API also doesn't change
for the same reason. (The OCaml API _does_ change but not
significantly).
I've run out of time on this patch today because I've got meetings for
the rest of the day (and it's only 11am!) However if I did have more
time there would be a 7th patch in the series which renames all
aio_*_callback functions to simply aio_*. eg. nbd_aio_pread_callback
is renamed to nbd_aio_pread (and old nbd_aio_pread is removed). That
is obviously a somewhat large albeit it mechanical API change.
Rich.
4 years, 9 months
[PATCH 0/3] generator: pod2text-related improvements
by Pino Toscano
- refactor memoization code
- pass pod as stdin rather than files
Pino Toscano (3):
generator: isolate memoized cache in own module
generator: adjust variable names
generator: improve pod2text invocation
generator/Makefile.am | 3 ++
generator/memoized_cache.ml | 62 +++++++++++++++++++++
generator/memoized_cache.mli | 29 ++++++++++
generator/utils.ml | 101 +++++++++++++++--------------------
4 files changed, 137 insertions(+), 58 deletions(-)
create mode 100644 generator/memoized_cache.ml
create mode 100644 generator/memoized_cache.mli
--
2.21.0
4 years, 9 months
[PATCH 1/2] Rust bindings: Add long description
by Hiroyuki Katsura
`cargo doc` will generate docs with long descriptions.
I did not add the settings of outputting these docs to `/website`.
This is because
- by publishing this crate to crates.io, users can see the docs in
`docs.rs` like `https://docs.rs/guestfs/<version>/guestfs/`. It is easy
to hold multiple documents corresponding to each version.
- the style of the documents generated by `cargo doc` is far different
from the documents which already exist.
---
generator/rust.ml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/generator/rust.ml b/generator/rust.ml
index 1f5cefa62..3a07c3b53 100644
--- a/generator/rust.ml
+++ b/generator/rust.ml
@@ -52,6 +52,14 @@ let translate_bad_symbols s =
else
s
+(* output longdesc to the rust file *)
+let pr_longdesc name longdesc indent_depth =
+ let l = pod2text name longdesc in
+ List.iter (fun x ->
+ indent indent_depth;
+ pr "/// %s\n" x;
+ ) l
+
let generate_rust () =
generate_header ~copyrights CStyle LGPLv2plus;
@@ -398,6 +406,8 @@ extern \"C\" {
style = (ret, args, optargs) } as f) ->
let cname = snake2caml name in
pr " /// %s\n" shortdesc;
+ pr " ///\n";
+ pr_longdesc name longdesc 1;
pr " #[allow(non_snake_case)]\n";
pr " pub fn %s" name;
--
2.20.1 (Apple Git-117)
4 years, 9 months
