6:50 p.m.
Hi,
Debian calls qemu-kvm kvm so we should check for that one too. Please
apply.
Cheers,
-- Guido
6:01 a.m.
On Fri, Nov 05, 2010 at 12:50:55AM +0100, Guido Günther wrote:
Hi,
Debian calls qemu-kvm kvm so we should check for that one too. Please
apply.
Cheers,
-- Guido
>From 41b7117ea9ffb6cbc42e0a8be619062224156dd3 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
Date: Fri, 5 Nov 2010 00:48:25 +0100
Subject: [PATCH] Debian calls qemu-kvm kvm
so check for that too.
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index da37b8d..13ad5f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -233,7 +233,7 @@ AM_CONDITIONAL([HAVE_XMLLINT],[test "x$XMLLINT" !=
"xno"])
dnl Check for QEMU for running binaries on this $host_cpu, fall
dnl back to basic 'qemu'. Allow the user to override it.
-default_qemu="qemu-kvm qemu-system-$host_cpu qemu"
+default_qemu="qemu-kvm qemu-system-$host_cpu qemu kvm"
Don't you want 'kvm' at the start of the list, otherwise it'll probably
find the plain TCG based QEMU first.
AC_ARG_WITH([qemu],
[AS_HELP_STRING([--with-qemu],
[set default QEMU binary @<:@default=[qemu-kvm] qemu-system-<host>
qemu@:>@])],
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
7:03 a.m.
On Fri, Nov 05, 2010 at 11:01:29AM +0000, Daniel P. Berrange wrote:
On Fri, Nov 05, 2010 at 12:50:55AM +0100, Guido Günther wrote:
> Hi,
> Debian calls qemu-kvm kvm so we should check for that one too. Please
> apply.
> Cheers,
> -- Guido
> >From 41b7117ea9ffb6cbc42e0a8be619062224156dd3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
> Date: Fri, 5 Nov 2010 00:48:25 +0100
> Subject: [PATCH] Debian calls qemu-kvm kvm
>
> so check for that too.
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index da37b8d..13ad5f9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -233,7 +233,7 @@ AM_CONDITIONAL([HAVE_XMLLINT],[test "x$XMLLINT" !=
"xno"])
>
> dnl Check for QEMU for running binaries on this $host_cpu, fall
> dnl back to basic 'qemu'. Allow the user to override it.
> -default_qemu="qemu-kvm qemu-system-$host_cpu qemu"
> +default_qemu="qemu-kvm qemu-system-$host_cpu qemu kvm"
Don't you want 'kvm' at the start of the list, otherwise it'll probably
find the plain TCG based QEMU first.
ACK.
Guido, do you want me to put kvm _second_ in the list as per Dan's
suggestion?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
8:37 a.m.
On Fri, Nov 05, 2010 at 12:03:33PM +0000, Richard W.M. Jones wrote:
On Fri, Nov 05, 2010 at 11:01:29AM +0000, Daniel P. Berrange wrote:
> On Fri, Nov 05, 2010 at 12:50:55AM +0100, Guido Günther wrote:
> > Hi,
> > Debian calls qemu-kvm kvm so we should check for that one too. Please
> > apply.
> > Cheers,
> > -- Guido
>
> > >From 41b7117ea9ffb6cbc42e0a8be619062224156dd3 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
> > Date: Fri, 5 Nov 2010 00:48:25 +0100
> > Subject: [PATCH] Debian calls qemu-kvm kvm
> >
> > so check for that too.
> > ---
> > configure.ac | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index da37b8d..13ad5f9 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -233,7 +233,7 @@ AM_CONDITIONAL([HAVE_XMLLINT],[test "x$XMLLINT"
!= "xno"])
> >
> > dnl Check for QEMU for running binaries on this $host_cpu, fall
> > dnl back to basic 'qemu'. Allow the user to override it.
> > -default_qemu="qemu-kvm qemu-system-$host_cpu qemu"
> > +default_qemu="qemu-kvm qemu-system-$host_cpu qemu kvm"
>
> Don't you want 'kvm' at the start of the list, otherwise it'll
probably
> find the plain TCG based QEMU first.
ACK.
Guido, do you want me to put kvm _second_ in the list as per Dan's
suggestion?
Yes, that's even better. Thank you for fixing this up.
-- Guido
8:44 a.m.
On Fri, Nov 05, 2010 at 02:37:29PM +0100, Guido Günther wrote:
On Fri, Nov 05, 2010 at 12:03:33PM +0000, Richard W.M. Jones wrote:
> On Fri, Nov 05, 2010 at 11:01:29AM +0000, Daniel P. Berrange wrote:
> > On Fri, Nov 05, 2010 at 12:50:55AM +0100, Guido Günther wrote:
> > > Hi,
> > > Debian calls qemu-kvm kvm so we should check for that one too. Please
> > > apply.
> > > Cheers,
> > > -- Guido
> >
> > > >From 41b7117ea9ffb6cbc42e0a8be619062224156dd3 Mon Sep 17 00:00:00
2001
> > > From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
> > > Date: Fri, 5 Nov 2010 00:48:25 +0100
> > > Subject: [PATCH] Debian calls qemu-kvm kvm
> > >
> > > so check for that too.
> > > ---
> > > configure.ac | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index da37b8d..13ad5f9 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -233,7 +233,7 @@ AM_CONDITIONAL([HAVE_XMLLINT],[test
"x$XMLLINT" != "xno"])
> > >
> > > dnl Check for QEMU for running binaries on this $host_cpu, fall
> > > dnl back to basic 'qemu'. Allow the user to override it.
> > > -default_qemu="qemu-kvm qemu-system-$host_cpu qemu"
> > > +default_qemu="qemu-kvm qemu-system-$host_cpu qemu kvm"
> >
> > Don't you want 'kvm' at the start of the list, otherwise it'll
probably
> > find the plain TCG based QEMU first.
>
> ACK.
>
> Guido, do you want me to put kvm _second_ in the list as per Dan's
> suggestion?
Yes, that's even better. Thank you for fixing this up.
Done already:
http://git.annexia.org/?p=libguestfs.git;a=commit;h=e51d6724d55c3a8c39b97...
and
http://git.annexia.org/?p=libguestfs.git;a=commit;h=7fc338690f385c2495b7b...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
5131
days inactive
5132
days old
4 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Guido Günther -
Richard W.M. Jones