Re: [Libguestfs] [PATCH nbdkit] cache, cow: Export block size constraints

> +/* Block size constraints. */ > +static int > +cache_block_size (nbdkit_next *next, void *handle, > + uint32_t *minimum, uint32_t *preferred, uint32_t *maximum) > +{ > + if (next->block_size (next, minimum, preferred, maximum) == -1) > + return -1; > + > + if (*minimum == 0) { /* No constraints set by the plugin. */ > + *minimum = 1; > + *preferred = blksize; > + *maximum = 0xffffffff; > + } > + else if (*maximum >= blksize) { Do we need braces here? > + *preferred = MAX (*preferred, blksize); > + }