Re: [Libguestfs] [PATCH] check for kvm

On Fri, Nov 05, 2010 at 12:03:33PM +0000, Richard W.M. Jones wrote: > On Fri, Nov 05, 2010 at 11:01:29AM +0000, Daniel P. Berrange wrote: > > On Fri, Nov 05, 2010 at 12:50:55AM +0100, Guido Günther wrote: > > > Hi, > > > Debian calls qemu-kvm kvm so we should check for that one too. Please > > > apply. > > > Cheers, > > > -- Guido > > > > > >From 41b7117ea9ffb6cbc42e0a8be619062224156dd3 Mon Sep 17 00:00:00 2001 > > > From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org&gt; > > > Date: Fri, 5 Nov 2010 00:48:25 +0100 > > > Subject: [PATCH] Debian calls qemu-kvm kvm > > > > > > so check for that too. > > > --- > > > configure.ac | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/configure.ac b/configure.ac > > > index da37b8d..13ad5f9 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -233,7 +233,7 @@ AM_CONDITIONAL([HAVE_XMLLINT],[test "x$XMLLINT" != "xno"]) > > > > > > dnl Check for QEMU for running binaries on this $host_cpu, fall > > > dnl back to basic 'qemu'. Allow the user to override it. > > > -default_qemu="qemu-kvm qemu-system-$host_cpu qemu" > > > +default_qemu="qemu-kvm qemu-system-$host_cpu qemu kvm" > > > > Don't you want 'kvm' at the start of the list, otherwise it'll probably > > find the plain TCG based QEMU first. > > ACK. > > Guido, do you want me to put kvm _second_ in the list as per Dan's > suggestion? Yes, that's even better. Thank you for fixing this up.