Re: [Libguestfs] [PATCH 0/8] v2v: various fixed for -o rhv-upload
On Mon, Sep 16, 2019 at 07:13:43PM +0200, Pino Toscano wrote:
This patch series fixes various issues in the rhv-upload output mode:
- properly find and use RHV resources
- cleanup orphan disks, and possibly the current disk transfer on
failure
In reality, the first 4 patches deal with resources, and the other 4
with cleanups. The latter block can be theoretically sent alone --
I just happened to start working on it as part of my "let's fix
rhv-upload oddities" initiative.
From the looks of it it all makes sense to me, but I did not have a chance to
try it out. I might have some tomorrow if you want someone to test it as well.
I've just one nitpick and that is the headers of newly created files which
mention (a) wring copyright year and/or (b) wrong file description. But that's
just a triviality due to copy pasting some duplicated comments.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)