Re: [Libguestfs] [PATCH nbdkit v2 1/4] partitioning plugin: Support MBR logical partitions.
On 1/21/19 12:15 PM, Richard W.M. Jones wrote:
---
.../nbdkit-partitioning-plugin.pod | 29 ++--
plugins/partitioning/virtual-disk.h | 12 +-
plugins/partitioning/partition-mbr.c | 132 +++++++++++++++---
plugins/partitioning/partitioning.c | 28 ++--
plugins/partitioning/virtual-disk.c | 42 +++++-
tests/Makefile.am | 4 +-
tests/test-partitioning5.sh | 96 +++++++++++++
7 files changed, 281 insertions(+), 62 deletions(-)
LGTM
Should we, at some point, allow the plugin user to specify the
advertised filesystem type and/or the boot flag for various partitions
(and not just that all file names presented are exposed as non-bootable
partitions of the same hard-coded type)? But that's a separate addition.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)