Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

On Thu, Sep 17, 2020 at 01:39:56PM +0100, Richard W.M. Jones wrote: The series looks good, I went through as much as I possibly could and that's why it took me so much time, sorry for that. What I like about it is that it is essentially just a different --type for the cryptsetup command and the rest is just refactors and clean-ups. So I'd say ACK from me (if that means anything), it's just one thing that I wanted to try out (and maybe you could create a test for it) and it did not work as expected. Basically what I did was create a small disk, create one partition over the whole disk, then cryptsetup luksFormat the partition, open it and format it with a filesystem (without any LVM). That is one of the things you were adding support for, but it is not limited to Windows Bitlocker setup, it can just as well be a custom setup when installing any Linux distro. Even after quite a bit of fighting, rebuilding the appliance and so on I did not manage for it to show up in the list-filesystems or even do a cryptsetup-open on the partition even though it uses an appliance built from git master with the patches applied. But I'm quite sure I could've done something wrong, so if that works for you, that's enough. Still, since you cannot do the test for Bitlocker, my idea was that you could make the test for non-lvm parition encrypted by LUKS as that would check some of the other code. Have a nice weekend, Martin