Re: [Libguestfs] [PATCH] v2v: Copy *.dll files since they can be part of the driver (RHBZ#1311373).

On Fri, Mar 04, 2016 at 09:11:00AM +0000, Richard W.M. Jones wrote: > Commit 47b5f245bec908f803f0a89c3b1e3166cfe33aad originally introduced > the filtering of files by extension. For the QXL driver at least, > there is a qxldd.dll file which is part of the driver, so that must be > copied to the guest as well. > > This patch will cause 'WdfCoInstaller*.dll' files to be copied too. > While I'm not sure if this is correct, It is. They are coinstaller dlls and are mentioned in the corresponding .inf and .cat files, so the driver wouldn't install without them. There are also other files that sometimes are and sometimes aren't referred to in the corresponding .inf. I think we need to stop filtering by extension at all and copy everything from the directory where .inf resides. > it seems as if it will be safe > as although there are multiple copies of this file, they are all the > same (per architecture). I wonder if we can stay with the flat structure at all...