Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size
On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones <rjones(a)redhat.com> wrote:
On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote:
> +static inline void
> +increase_queue_size(struct worker *worker, size_t len)
^ space
and the same in the next function:
Sure will fix before pushing.
Do we have a way to format the source automatically with spaces
before ()?
> +{
> + worker->queue_size += len;
> +}
> +
> +static inline void
> +decrease_queue_size(struct worker *worker, size_t len)
> +{
> + assert (worker->queue_size >= len);
> + worker->queue_size -= len;
> +}
Do we not need any locking here?
Since every worker thread accesses only its data, no locking is needed.