On Mon, Apr 01, 2019 at 10:14:44AM -0500, Eric Blake wrote:
On 4/1/19 10:09 AM, Martin Kletzander wrote:
>>> +++ b/TODO
>>> @@ -24,8 +24,8 @@ General ideas for improvements
>>> to inform nbdkit when the response is ready:
>>>
https://www.redhat.com/archives/libguestfs/2018-January/msg00149.html
>>>
>>> -* More NBD protocol features. The only currently missing feature is
>>> - online resize.
>>> +* More NBD protocol features. The only currently missing features are
>>> + sparse reads and online resize.
>>>
>
> This resets the change from commit 26455d452574, probably unintentionally?
The earlier commit had:
-* More NBD protocol features. In the upstream pipeline: proposals for
- block status and online resize.
+* More NBD protocol features. The only currently missing feature is
+ online resize.
We implemented block status (which can indirectly be used to avoid the
need for sparse reads, for the same effect), but we did not actually
implement sparse reads (where we send FAR less network traffic for
blocks that are known to read as zeroes). So my change in wording was
intentional.
Oh, thanks for the explanation, I did mistake sparse streams with block status.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
qemu.org |
libvirt.org